Skip to content

Conversation

@Siedlerchr
Copy link
Member

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 19, 2021
@Siedlerchr
Copy link
Member Author

@koppor The RFC fetcher fails due to your changes from #8238 for the comments field:

Notice the difference int the first two lines:
grafik

Expected:

Optional[%% You should probably cite draft-ietf-http-v10-spec instead of this I-D,@techreport{fielding-http-spec-01,
  abstract = {The Hypertext Transfer Protocol (HTTP) is an application-level protocol with the lightness and speed necessary for distributed, collaborative, hypermedia information systems. It is a generic, stateless, object-oriented protocol which can be used for many tasks, such as name servers and distributed object management systems, through extension of its request methods (commands). A feature of HTTP is the typing and negotiation of data representation, allowing systems to be built independently of the data being transferred. HTTP has been in use by the World-Wide Web global information initiative since 1990. This specification reflects preferred usage of the protocol referred to as 'HTTP/1.0', and is compatible with the most commonly used HTTP server and client programs implemented prior to November 1994.},
  author = {Henrik Nielsen and Roy T. Fielding and Tim Berners-Lee},
  day = {20},
  institution = {Internet Engineering Task Force},
  month = {#dec#},
  note = {Work in Progress},
  number = {draft-fielding-http-spec-01},
  pagetotal = {41},
  publisher = {Internet Engineering Task Force},
  title = {{Hypertext Transfer Protocol -- HTTP/1.0}},
  type = {Internet-Draft},
  url = {https://datatracker.ietf.org/doc/html/draft-fielding-http-spec-01},
  year = {1994},
  _jabref_shared = {sharedId: -1, version: 1}
}]

actual:

Optional[%% You should probably cite draft-ietf-http-v10-spec instead of this I-D.
@techreport{fielding-http-spec-01,
  abstract = {The Hypertext Transfer Protocol (HTTP) is an application-level protocol with the lightness and speed necessary for distributed, collaborative, hypermedia information systems. It is a generic, stateless, object-oriented protocol which can be used for many tasks, such as name servers and distributed object management systems, through extension of its request methods (commands). A feature of HTTP is the typing and negotiation of data representation, allowing systems to be built independently of the data being transferred. HTTP has been in use by the World-Wide Web global information initiative since 1990. This specification reflects preferred usage of the protocol referred to as 'HTTP/1.0', and is compatible with the most commonly used HTTP server and client programs implemented prior to November 1994.},
  author = {Henrik Nielsen and Roy T. Fielding and Tim Berners-Lee},
  day = {20},
  institution = {Internet Engineering Task Force},
  month = {#dec#},
  note = {Work in Progress},
  number = {draft-fielding-http-spec-01},
  pagetotal = {41},
  publisher = {Internet Engineering Task Force},
  title = {{Hypertext Transfer Protocol -- HTTP/1.0}},
  type = {Internet-Draft},
  url = {https://datatracker.ietf.org/doc/html/draft-fielding-http-spec-01},
  year = {1994},
  _jabref_shared = {sharedId: -1, version: 1}
}]

Probably related code:

public void setCommentsBeforeEntry(String parsedComments) {
this.commentsBeforeEntry = parsedComments;
}

@Siedlerchr Siedlerchr merged commit 5c96ddf into main Nov 21, 2021
@Siedlerchr Siedlerchr deleted the fixFetcherTestsAGAIN branch November 21, 2021 11:42
Siedlerchr added a commit that referenced this pull request Nov 22, 2021
* upstream/main:
  Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260)
  Bump checkstyle from 9.0.1 to 9.1 (#8266)
  Bump mockito-core from 4.0.0 to 4.1.0 (#8267)
  Bump classgraph from 4.8.130 to 4.8.135 (#8268)
  Fix some fetcher tests (#8258)
  Clicking a DOI link in the preview pane no longer crashes (#8255)
Siedlerchr added a commit that referenced this pull request Nov 30, 2021
* upstream/main:
  Consider directory pattern when checking if a file can be moved (#8244)
  Bump byte-buddy-parent from 1.12.1 to 1.12.2 (#8285)
  Bump unirest-java from 3.13.3 to 3.13.4 (#8283)
  Bump checkstyle from 9.1 to 9.2 (#8284)
  Bump classgraph from 4.8.135 to 4.8.137 (#8282)
  Do not resize main table columns in search dialog window (#8253)
  Fix NegativeArraySizeException (#8270)
  Update deployment.yml
  TEst
  Grand unified library properties (GRULPS) (#8264)
  Fixes RFC fetcher test case (#8271)
  Update Gradle Wrapper from 7.2 to 7.3 (#8246)
  Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260)
  Bump checkstyle from 9.0.1 to 9.1 (#8266)
  Bump mockito-core from 4.0.0 to 4.1.0 (#8267)
  Bump classgraph from 4.8.130 to 4.8.135 (#8268)
  Fix some fetcher tests (#8258)
  Clicking a DOI link in the preview pane no longer crashes (#8255)
@koppor koppor mentioned this pull request Mar 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants