Skip to content

Conversation

@stefan-kolb
Copy link
Member

Fixes #2574

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 20, 2017
@stefan-kolb stefan-kolb added this to the v4.0 milestone Feb 20, 2017
@Siedlerchr
Copy link
Member

Changelog and it's ready for merge!

@lenhard
Copy link
Member

lenhard commented Feb 21, 2017

Same here: Looks good code-wise.

Please add a Changelog entry and merge!

@Siedlerchr
Copy link
Member

And please fix codacy by making the one field final static

@stefan-kolb stefan-kolb merged commit 428ae43 into master Feb 21, 2017
@stefan-kolb stefan-kolb deleted the fix-sciencedirect branch February 21, 2017 17:55
Siedlerchr added a commit that referenced this pull request Feb 23, 2017
* upstream/master:
  Revert "Update gradle from 3.3 to 3.4"
  Localization tests (#2582)
  Update IEEEJournalList (#2579)
  Keyword - Special field synchronization (#2583)
  Update gradle from 3.3 to 3.4
  Check similarity of entry when using DOI retrieval with ArXiV (#2575)
  Add logic for new Sciencedirect pages (#2576)
  [WIP] Refactored around the FileAnnotationCache. (#2557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants