Skip to content

Conversation

@Ede123
Copy link
Contributor

@Ede123 Ede123 commented Feb 21, 2017

Update for IEEEJournalListCode.txt and IEEEJournalListText.txt compiled from IEEEfull.bib and IEEEabrv.bib respectively.

("China Communications" seems to be the preferred name)
@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 22, 2017
@Siedlerchr
Copy link
Member

Thank you very much for your contribution. I am not an expert in the IEEE Abbrev codes but to me it looks good.

@LinusDietz
Copy link
Member

Would it be advisable to write an automated script that fetches those lists automatically before each release?

@Ede123
Copy link
Contributor Author

Ede123 commented Feb 22, 2017

The files were last changed 2015/08/28. Probably not be worth the effort...

Copy link
Member

@LinusDietz LinusDietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@koppor koppor merged commit 546423a into JabRef:master Feb 22, 2017
@koppor
Copy link
Member

koppor commented Feb 22, 2017

Thank you for the PR! I think, syncing it with existing lists, is a very good idea!

Is there a script you wrote or is it manual effort? 🌞

@Ede123 Ede123 deleted the IEEEJournalList branch February 22, 2017 21:50
@Ede123
Copy link
Contributor Author

Ede123 commented Feb 22, 2017

No, half-auto using regex and Notepad++

Siedlerchr added a commit that referenced this pull request Feb 23, 2017
* upstream/master:
  Revert "Update gradle from 3.3 to 3.4"
  Localization tests (#2582)
  Update IEEEJournalList (#2579)
  Keyword - Special field synchronization (#2583)
  Update gradle from 3.3 to 3.4
  Check similarity of entry when using DOI retrieval with ArXiV (#2575)
  Add logic for new Sciencedirect pages (#2576)
  [WIP] Refactored around the FileAnnotationCache. (#2557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants