Skip to content

Fix navigation in entry editor increases modifies font size #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2017
Merged

Fix navigation in entry editor increases modifies font size #3037

merged 2 commits into from
Jul 22, 2017

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jul 21, 2017 •
edited
Loading

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@koppor koppor self-requested a review July 21, 2017 17:01
koppor
koppor approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG. What funny constant names. As this also solved similar issues, no objections from my side.

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Jul 21, 2017

The only thing which does not yet work is ctrl+MINUS, it always decreases the font size although I added the exception here. Did not yet figure out the problem. Maybe @lenhard can have a look at that, too.

@Siedlerchr
Chanbge key event filter to keyPressed only
404fa0e 
Move entry editor keykinding for decrease table font size
@Siedlerchr Siedlerchr merged commit 3344c62 into master Jul 22, 2017
@Siedlerchr Siedlerchr deleted the entryEditorKeys branch July 22, 2017 10:41
@Siedlerchr
Copy link
Member Author

Siedlerchr commented Jul 22, 2017

Found the problem. The decreasing font size was found first and returned before the entry editor panel constant, because both have the same keymapping

Siedlerchr added a commit that referenced this pull request Jul 31, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
b6d43dc 
* upstream/master: (41 commits)
  update xmlunit from 2.3.0 -> 2.4.0
  update wiremock from 2.6.0 -> 2.7.0
  update controlsfx from 8.40.12 -> 8.40.13
  Fix group freeze by running markBasechange in swing thread (#3058)
  Localization: French: translation of new entries (#3050)
  Fix ads fetcher (#3048)
  Update translation (#3041)
  Translate new strings (#3040)
  Fix navigation in entry editor increases modifies font size (#3037)
  Initial idea for architectural decision records (#3033)
  Readd comment
  Readd comment
  Fix keybdining in entry editor in localized installation (#3030)
  Structuring
  Upgrade shadowJar
  Modernizer improvements
  Replace Reimplement MappedList.kt (#3032)
  Use https for the maven ej-technologies repo
  Upgrade modernizer plugin
  Remove separator next to search bar
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Siedlerchr @koppor