Bibentrysource contextmenu #5007

calixtus · 2019-05-29T01:06:36Z

I was missing a context-menu in the source-editor. So I made one. ;-)

~~It still looks ugly, it copies the font-family from the codeArea, but i have no idea what css-property i have to change... do you have an idea @davidemdot? You already solved some css-issues.~~

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

src/main/java/org/jabref/gui/entryeditor/SourceTab.java

calixtus · 2019-05-29T07:52:34Z

A different question is, if this source Editor shouldn't be seperated from the tab and get its own class, like every other fieldeditor. This would mean only a little bit of refactoring, but I don't want to interfere with your efforts of refactoring the entryeditor itself. So this small addition is probably better towards preparing 5.0-stable and wait until after the release for the big overhaul.

Siedlerchr · 2019-05-29T07:57:24Z

I currently see it not necessary to do any further refactorings (also in hindsight of my other pr #4897, as thsi would result in a lot of merge conflicts)

calixtus · 2019-05-29T08:39:16Z

Ready for review. ;-)

…ntextmenu

davidemdot · 2019-06-01T04:08:03Z

I am sorry, @calixtus. I have been busy this week and just saw your mention. How nice you have solved those problems!

# Conflicts: # CHANGELOG.md

tobiasdiez

LGTM! Please resolve the conflicts, then we can merge. Thanks!

…ntextmenu # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/gui/entryeditor/SourceTab.java

calixtus · 2019-06-09T21:00:35Z

Sorry, took me a while, I concentrated on the other PR. Ready to merge

matthiasgeiger · 2019-06-10T06:58:31Z

Thank you very much for your contribution! 👍

26265bf Create pacific-science.csl (JabRef#5020) e6ff62e Update pravnik.csl & iso690-full-note-cs.csl (JabRef#5019) 8ab9362 Create turabian-9-author-date (JabRef#4796) 28c7021 Update west-european-politics.csl (JabRef#4900) 6d06e5e Create american-physical-society-et-al (JabRef#4974) 7472744 Create farmeconomia.csl (JabRef#5017) bd916df Create amerindia.csl (JabRef#5011) 28d176d Create law-technology-and-humans-journal-style.csl (JabRef#5015) a998aa5 Create kerala-journal-of-ophthalmology.csl (JabRef#5014) 8662257 Update journal-of-australian-strength-and-conditioning.csl (JabRef#5010) e28f06f Create clinical-management-issues.csl (JabRef#5008) abb92fb Create institut-francais-darcheologie-orientale-en.csl (JabRef#4870) f931c78 Update institut-francais-darcheologie-orientale.csl (JabRef#4869) 9d604ca Update journal-of-foraminiferal-research.csl 1191d07 add Journal of Foraminiferal Research (JabRef#5007) 0903e9d Update molecular-therapy.csl (JabRef#5009) 316d6c7 Update journal-of-alzheimers-disease.csl (JabRef#5006) 868a7ed Create journal-of-soil-science-and-plant-nutrition (JabRef#5005) 875ef81 Create universitat-bern-institut-fur-sozialanthropologie.csl (JabRef#4998) 1194b81 Create journal-de-la-societe-des-americanistes.csl (JabRef#4995) 1d2a472 Update international-energy-agency-organisation-for-economic-co-operation-and-development.csl (JabRef#4999) 02a26ef Update iso690-author-date-cs.csl (JabRef#5003) 165592c Create european-journal-of-entomology.csl (JabRef#5001) 4d587ca Create european-journal-of-anaesthesiology.csl (JabRef#5002) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 26265bf

26265bf Create pacific-science.csl (#5020) e6ff62e Update pravnik.csl & iso690-full-note-cs.csl (#5019) 8ab9362 Create turabian-9-author-date (#4796) 28c7021 Update west-european-politics.csl (#4900) 6d06e5e Create american-physical-society-et-al (#4974) 7472744 Create farmeconomia.csl (#5017) bd916df Create amerindia.csl (#5011) 28d176d Create law-technology-and-humans-journal-style.csl (#5015) a998aa5 Create kerala-journal-of-ophthalmology.csl (#5014) 8662257 Update journal-of-australian-strength-and-conditioning.csl (#5010) e28f06f Create clinical-management-issues.csl (#5008) abb92fb Create institut-francais-darcheologie-orientale-en.csl (#4870) f931c78 Update institut-francais-darcheologie-orientale.csl (#4869) 9d604ca Update journal-of-foraminiferal-research.csl 1191d07 add Journal of Foraminiferal Research (#5007) 0903e9d Update molecular-therapy.csl (#5009) 316d6c7 Update journal-of-alzheimers-disease.csl (#5006) 868a7ed Create journal-of-soil-science-and-plant-nutrition (#5005) 875ef81 Create universitat-bern-institut-fur-sozialanthropologie.csl (#4998) 1194b81 Create journal-de-la-societe-des-americanistes.csl (#4995) 1d2a472 Update international-energy-agency-organisation-for-economic-co-operation-and-development.csl (#4999) 02a26ef Update iso690-author-date-cs.csl (#5003) 165592c Create european-journal-of-entomology.csl (#5001) 4d587ca Create european-journal-of-anaesthesiology.csl (#5002) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 26265bf

26265bf Create pacific-science.csl (JabRef#5020) e6ff62e Update pravnik.csl & iso690-full-note-cs.csl (JabRef#5019) 8ab9362 Create turabian-9-author-date (JabRef#4796) 28c7021 Update west-european-politics.csl (JabRef#4900) 6d06e5e Create american-physical-society-et-al (JabRef#4974) 7472744 Create farmeconomia.csl (JabRef#5017) bd916df Create amerindia.csl (JabRef#5011) 28d176d Create law-technology-and-humans-journal-style.csl (JabRef#5015) a998aa5 Create kerala-journal-of-ophthalmology.csl (JabRef#5014) 8662257 Update journal-of-australian-strength-and-conditioning.csl (JabRef#5010) e28f06f Create clinical-management-issues.csl (JabRef#5008) abb92fb Create institut-francais-darcheologie-orientale-en.csl (JabRef#4870) f931c78 Update institut-francais-darcheologie-orientale.csl (JabRef#4869) 9d604ca Update journal-of-foraminiferal-research.csl 1191d07 add Journal of Foraminiferal Research (JabRef#5007) 0903e9d Update molecular-therapy.csl (JabRef#5009) 316d6c7 Update journal-of-alzheimers-disease.csl (JabRef#5006) 868a7ed Create journal-of-soil-science-and-plant-nutrition (JabRef#5005) 875ef81 Create universitat-bern-institut-fur-sozialanthropologie.csl (JabRef#4998) 1194b81 Create journal-de-la-societe-des-americanistes.csl (JabRef#4995) 1d2a472 Update international-energy-agency-organisation-for-economic-co-operation-and-development.csl (JabRef#4999) 02a26ef Update iso690-author-date-cs.csl (JabRef#5003) 165592c Create european-journal-of-entomology.csl (JabRef#5001) 4d587ca Create european-journal-of-anaesthesiology.csl (JabRef#5002) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 26265bf

calixtus added 5 commits May 29, 2019 02:36

Added ContextMenu

21d2d09

Refactor deprecated Actions

5112363

changelog

9165877

whitespace

11cf1e4

whitespaces the second

e6dc8d7

Siedlerchr reviewed May 29, 2019

View reviewed changes

src/main/java/org/jabref/gui/entryeditor/SourceTab.java Outdated Show resolved Hide resolved

calixtus added 2 commits May 29, 2019 09:33

fix codeArea

2057a10

Added styleclass

d536e3d

calixtus changed the title ~~[WIP] Bibentrysource contextmenu~~ Bibentrysource contextmenu May 29, 2019

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 29, 2019

Forgot requestFocus

1f85257

calixtus added 2 commits May 29, 2019 10:46

Whitespace and refactor

9683656

Merge remote-tracking branch 'upstream/master' into bibentrysource-co…

8dc2b3d

…ntextmenu

calixtus added 2 commits June 5, 2019 00:29

Merge branch 'master' into bibentrysource-contextmenu

983b643

# Conflicts: # CHANGELOG.md

Changelog

b4dbbcc

tobiasdiez approved these changes Jun 6, 2019

View reviewed changes

calixtus added 2 commits June 9, 2019 22:50

Merge remote-tracking branch 'upstream/master' into bibentrysource-co…

244f2c5

…ntextmenu # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/gui/entryeditor/SourceTab.java

Checkstyle

29f8830

calixtus added 3 commits June 9, 2019 23:04

minor corrections

a64a5bf

minor corrections

5126048

Refactor overlooked

35c6b6a

matthiasgeiger merged commit eb42850 into JabRef:master Jun 10, 2019

calixtus deleted the bibentrysource-contextmenu branch June 10, 2019 07:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bibentrysource contextmenu #5007

Bibentrysource contextmenu #5007

Uh oh!

calixtus commented May 29, 2019 •

edited

Loading

Uh oh!

Uh oh!

calixtus commented May 29, 2019

Uh oh!

Siedlerchr commented May 29, 2019

Uh oh!

calixtus commented May 29, 2019 •

edited

Loading

Uh oh!

davidemdot commented Jun 1, 2019

Uh oh!

tobiasdiez left a comment

Uh oh!

calixtus commented Jun 9, 2019

Uh oh!

matthiasgeiger commented Jun 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Bibentrysource contextmenu #5007

Bibentrysource contextmenu #5007

Uh oh!

Conversation

calixtus commented May 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

calixtus commented May 29, 2019

Uh oh!

Siedlerchr commented May 29, 2019

Uh oh!

calixtus commented May 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidemdot commented Jun 1, 2019

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

calixtus commented Jun 9, 2019

Uh oh!

matthiasgeiger commented Jun 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

calixtus commented May 29, 2019 •

edited

Loading

calixtus commented May 29, 2019 •

edited

Loading