Skip to content

Disable certain fetcher tests on CI #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Disable certain fetcher tests on CI #7348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5746cf4
Disable Google Scholar tests
koppor Jan 14, 2021
251ea9a
Disalbe JSTOR tests on CI and cleanup GoogleScholarTest
koppor Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/test/java/org/jabref/logic/importer/fetcher/GoogleScholarTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import static org.mockito.Mockito.when;

@FetcherTest
@DisabledOnCIServer("CI server is blocked by Google")
class GoogleScholarTest implements SearchBasedFetcherCapabilityTest, PagedSearchFetcherTest {

private GoogleScholar finder;
Expand All @@ -40,7 +41,6 @@ void setUp() {
}

@Test
@DisabledOnCIServer("CI server is blocked by Google")
void linkFound() throws IOException, FetcherException {
entry.setField(StandardField.TITLE, "Towards Application Portability in Platform as a Service");

Expand All @@ -51,15 +51,13 @@ void linkFound() throws IOException, FetcherException {
}

@Test
@DisabledOnCIServer("CI server is blocked by Google")
void noLinkFound() throws IOException, FetcherException {
entry.setField(StandardField.TITLE, "Curriculum programme of career-oriented java specialty guided by principles of software engineering");

assertEquals(Optional.empty(), finder.findFullText(entry));
}

@Test
@DisabledOnCIServer("CI server is blocked by Google")
void findSingleEntry() throws FetcherException {
entry.setType(StandardEntryType.InProceedings);
entry.setCitationKey("geiger2013detecting");
Expand All @@ -75,7 +73,6 @@ void findSingleEntry() throws FetcherException {
}

@Test
@DisabledOnCIServer("CI server is blocked by Google")
void findManyEntries() throws FetcherException {
List<BibEntry> foundEntries = finder.performSearch("random test string");

Expand Down
2 changes: 2 additions & 0 deletions src/test/java/org/jabref/logic/importer/fetcher/JstorFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import org.jabref.model.entry.BibEntry;
import org.jabref.model.entry.field.StandardField;
import org.jabref.model.entry.types.StandardEntryType;
import org.jabref.support.DisabledOnCIServer;
import org.jabref.testutils.category.FetcherTest;

import org.junit.jupiter.api.Disabled;
Expand All @@ -22,6 +23,7 @@
import static org.mockito.Mockito.mock;

@FetcherTest
@DisabledOnCIServer("CI server is blocked by JSTOR")
public class JstorFetcherTest implements SearchBasedFetcherCapabilityTest {

private final JstorFetcher fetcher = new JstorFetcher(mock(ImportFormatPreferences.class, Answers.RETURNS_DEEP_STUBS));
Expand Down