Re-impose "no double lookup" for invoke #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
- Coverage 85.71% 85.67% -0.05%
==========================================
Files 12 12
Lines 2415 2415
==========================================
- Hits 2070 2069 -1
- Misses 345 346 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
pfitzseb
approved these changes
Jul 24, 2022
simeonschaub
requested changes
Jul 24, 2022
Collaborator
simeonschaub
left a comment
simeonschaub
left a comment
There was a problem hiding this comment.
Could you update bin/generate_builtins.jl correspondingly, so it's not out of sync with this file?
simeonschaub
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #442 and inadvertently removed in #532.
However, the test in #442 was not stringent enough; the test added here
comes from #535.
Fixes #535
Fixes timholy/Revise.jl#695