Skip to content

Conversation

@t-bltg
Copy link
Collaborator

@t-bltg t-bltg commented Jul 24, 2022

No description provided.

@t-bltg t-bltg force-pushed the cov branch 3 times, most recently from 6ddc7ef to f35e1c0 Compare July 24, 2022 20:41
@timholy
Copy link
Owner

timholy commented Jul 25, 2022

Let's see if CI has been fixed by JuliaDebug/JuliaInterpreter.jl#540

@timholy timholy closed this Jul 25, 2022
@timholy timholy reopened this Jul 25, 2022
@timholy
Copy link
Owner

timholy commented Jul 25, 2022

Fixing nightly will be something for future work. JuliaInterpreter isn't passing on nightly either, so that's the right place to start. And #694 is one known failure, but let's wait on hearing about JuliaLang/julia#45441.

@t-bltg
Copy link
Collaborator Author

t-bltg commented Jul 25, 2022

Yes, nightly ... is nightly 🤷, expected to break from time to time. Thanks for the invite to collaborate on Revise.jl btw.

This is only a moderate increase in coverage, but any step towards 100% is good to take I guess.

@timholy
Copy link
Owner

timholy commented Jul 25, 2022

Feel free to merge at will!

@t-bltg
Copy link
Collaborator Author

t-bltg commented Jul 25, 2022

With great power comes great responsibility ;)

@t-bltg t-bltg merged commit fe8d3b4 into timholy:master Jul 25, 2022
@t-bltg t-bltg deleted the cov branch July 25, 2022 15:02
@timholy
Copy link
Owner

timholy commented Jul 25, 2022

That sentiment is a prerequisite :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants