Skip to content
This repository was archived by the owner on Oct 22, 2021. It is now read-only.

Conversation

@simonschoelly
Copy link
Member

Most of the stuff works, but the package Clp.jl is not yet ready for version 1.0. Therefore the tests fail and mincost_flow does not work yet.

Should also remove most of the warnings in #18

@matbesancon
Copy link
Member

oh wonderful thanks!
For the parametric functions I'm not sure SimpleTraits.jl supports the where syntax

@matbesancon
Copy link
Member

Also, I think we can change the travis config:

julia:
  - 0.7
  - 1.0
  - nightly

matrix:
  allow_failures:
- julia: nightly

@simonschoelly
Copy link
Member Author

I changed the travis config. There is also appveyor config that defaults to version 0.6 but I'm not familiar with that.
SimpleTraits does support the where syntax, you just have to be a bit careful when you have multiple arguments in the where clause.

@coveralls
Copy link

coveralls commented Aug 27, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling dd24242 on simonschoelly:fixes_for_v1.0 into c64661c on JuliaGraphs:master.

@matbesancon
Copy link
Member

To update appveyor if you can: https://github.com/JuliaCI/Appveyor.jl
The readme example is up to date for 1.0, copy-pasting should just work, uncomment the nightly fail allowed and we're god

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #19    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          11     10     -1     
  Lines         419    280   -139     
======================================
- Hits          419    280   -139
Impacted Files Coverage Δ
src/ext_multiroute_flow.jl 100% <ø> (ø) ⬆️
src/push_relabel.jl 100% <ø> (ø) ⬆️
src/dinic.jl 100% <100%> (ø) ⬆️
src/maximum_flow.jl 100% <100%> (ø) ⬆️
src/boykov_kolmogorov.jl 100% <100%> (ø) ⬆️
src/edmonds_karp.jl 100% <100%> (ø) ⬆️
src/mincost.jl 100% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64661c...dd24242. Read the comment docs.

@simonschoelly
Copy link
Member Author

Appveyor is running now but Windows has problems with clp on all versions. The other tests all pass:
https://ci.appveyor.com/project/simonschoelly/lightgraphsflows-jl/build/1.0.10

@matbesancon
Copy link
Member

yes clp is supposedly good on 0.7, not sure about 1.0 they didn't put it in their CI scripts, I'll PR them for it

@matbesancon
Copy link
Member

jump-dev/Clp.jl#32

@juliohm
Copy link
Member

juliohm commented Aug 29, 2018

Thank you @simonschoelly for your work. What is the status?

@simonschoelly
Copy link
Member Author

Until Clp.jl and Cbc.jl, which is a dependency for the former, work on 1.0, the tests can't pass.

See jump-dev/Clp.jl#31 and jump-dev/Cbc.jl#54.

@simonschoelly
Copy link
Member Author

Clp runs on Julia v1.0 now, so this PR could probably be merged.

@matbesancon
Copy link
Member

Wonderful, merging as soon as CI passes, thanks @simonschoelly !

@matbesancon matbesancon merged commit eff807b into JuliaGraphs:master Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants