Skip to content

Call get_compiler_cmd() at the beginning of create_sysimage and create_app #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Call get_compiler_cmd() at the beginning of create_sysimage and create_app #770

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
175812c
Call `get_compiler_cmd()` at the beginning of `create_sysimage` and `…
DilumAluthge Jan 26, 2023
cda75a9
Add some comments
DilumAluthge Jan 27, 2023
89caaef
Apply suggestions from code review
DilumAluthge Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/PackageCompiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,9 @@ function create_sysimage(packages::Union{Nothing, Symbol, Vector{String}, Vector
compat_level::String="major",
extra_precompiles::String = "",
)
# We call this at the very beginning to make sure that the user has a compiler available. Therefore, if no compiler
# is found, we throw an error immediately, instead of making the user wait a while before the error is thrown.
get_compiler_cmd()

if filter_stdlibs && incremental
error("must use `incremental=false` to use `filter_stdlibs=true`")
Expand Down Expand Up @@ -748,6 +751,9 @@ function create_app(package_dir::String,
sysimage_build_args::Cmd=``,
include_transitive_dependencies::Bool=true)
warn_official()
# We call this at the very beginning to make sure that the user has a compiler available. Therefore, if no compiler
# is found, we throw an error immediately, instead of making the user wait a while before the error is thrown.
get_compiler_cmd()

ctx = create_pkg_context(package_dir)
ctx.env.pkg === nothing && error("expected package to have a `name`-entry")
Expand Down