Call get_compiler_cmd() at the beginning of create_sysimage and create_app
#770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 81.54% 81.59% +0.05%
==========================================
Files 3 3
Lines 661 663 +2
==========================================
+ Hits 539 541 +2
Misses 122 122
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I'm not sure what the current state of CI is. @IanButterworth Are these CI failures expected? |
|
1.6 won't pass. The rest should but there are gremlins |
Co-authored-by: Ian Butterworth <[email protected]>
IanButterworth
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way, users will immediately get an error if a compiler cannot be found, instead of having to wait a long time before the error is thrown.
Replaces #769
Closes #769
Closes #677
Closes #727