sjk/warn early1 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create_app` (JuliaLang#770) Co-authored-by: Ian Butterworth <[email protected]> Co-authored-by: Ian Butterworth <[email protected]>
…ect.toml` file (JuliaLang#771) * Skip broken tests on 1.6 CI * Update runtests.jl * Remove some CI jobs while debugging this PR * Update Project.toml * Update runtests.jl * Update test.yml * Apply suggestions from code review Co-authored-by: Ian Butterworth <[email protected]> --------- Co-authored-by: Ian Butterworth <[email protected]>
This removes the enforced `-O` and `g` levels, and propogates the passed arguments to the entire build. We filter a few arguments from the base sysimg to prevent some failures and avoid known bugs.
This solves issue in https://discourse.julialang.org/t/plots-do-not-display-unless-i-call-gui-when-using-custom-sysimage/92207 Co-authored-by: Dilum Aluthge <[email protected]>
Signed-off-by: Alexander Seiler <[email protected]>
Co-authored-by: Kristoffer Carlsson <[email protected]>
…Union{Nothing, String}` kwarg (JuliaLang#788)
Co-authored-by: Kristoffer Carlsson <[email protected]>
- Sysimages built with CPU targets as env var, tend to ignore them and result segfaults, when relocated to the target machine
This possible error happens late in the build, so this change will make it error earlier for the user. Should improve experience a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_compiler_cmd()at the beginning ofcreate_sysimageandcreate_app(Callget_compiler_cmd()at the beginning ofcreate_sysimageandcreate_appJuliaLang/PackageCompiler.jl#770)LLVMExtra_jllfrom theMyApp/Project.tomlfile (Test suite: on Julia 1.6, removeLLVMExtra_jllfrom theMyApp/Project.tomlfile JuliaLang/PackageCompiler.jl#771)ci_startedjob (CI: add theci_startedjob JuliaLang/PackageCompiler.jl#776)projectarg should be a path. (clarify thatprojectarg should be a path. JuliaLang/PackageCompiler.jl#773)MyLib(Build and runMyLibJuliaLang/PackageCompiler.jl#732)create_appfunction to accept and propagate thescript::Union{Nothing, String}kwarg (Allow thecreate_appfunction to accept and propagate thescript::Union{Nothing, String}kwarg JuliaLang/PackageCompiler.jl#788)uuidtoo in error (Mentionuuidtoo in error JuliaLang/PackageCompiler.jl#733)julia_main(fix importing executable before trying to compile itsjulia_mainJuliaLang/PackageCompiler.jl#813)sysimage_path