Pass CPU targets as cmdline args

[ven-k]

• Fixes With 1.9.0-beta4, sysimages aren't built for the specified JULIA_CPU_TARGET #790
• JULIA_CPU_TARGETS are ignored while building sysimage 1.9-rc2
• Sysimages built with CPU targets as env var, tend to ignore them and result segfaults, when relocated to the target machine
  (See¹) (On Julia#master and Julia#backports-release-1.9)
• I've locally tested the PR against Julia binary² associated with latest commit³ on Backport to 1.9 PR

Footnotes

1. https://github.com/JuliaLang/julia/pull/48809#issuecomment-1505546852 ↩

2. https://buildkite.com/organizations/julialang/pipelines/julia-release-1-dot-9/builds/175/jobs/01878fbd-b60d-4609-90a7-af65eb2e8bcb/artifacts/0187900b-8624-4214-9fae-c1b8247fc16d ↩

3. https://github.com/JuliaLang/julia/commit/00334655d2c46da4693d41a0d69fa9a089a71df4 ↩

[codecov]

Codecov Report

Merging #804 (bb14715) into master (ef46e40) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
- Coverage   82.98%   82.59%   -0.39%     
==========================================
  Files           3        3              
  Lines         670      655      -15     
==========================================
- Hits          556      541      -15     
  Misses        114      114              

Impacted Files	Coverage Δ
src/PackageCompiler.jl	92.78% <100.00%> (-0.21%)	⬇️

[ven-k]

• Once the next release of 1.9.0-* is out, 'will re-run the corr. tests.

• The failure¹ on 1.10-dev is unrelated

filter = false: Error During Test at D:\a\PackageCompiler.jl\PackageCompiler.jl\test\runtests.jl:80
  Got exception outside of a @test
  Unable to automatically download/install artifact 'fooifier' from sources listed in 'C:\Users\runneradmin\AppData\Local\Temp\jl_kTjrxv\MyApp\Artifacts.toml'.
  Sources attempted:
  - https://pkg.julialang.org/artifact/d61f806c76b57e54f343634c5219d00d4c81b077
      Error: RequestError: HTTP/1.1 404 Not Found while requesting https://pkg.julialang.org/artifact/d61f806c76b57e54f343634c5219d00d4c81b077
  - https://github.com/staticfloat/small_bin/raw/master/libfoo/libfoo.x86_64-w64-mingw32.tar.gz
      Error: Tree Hash Mismatch!
    Expected git-tree-sha1:   d61f806c76b57e54f343634c5219d00d4c81b077
    Calculated git-tree-sha1: 1[351](https://github.com/JuliaLang/PackageCompiler.jl/actions/runs/4730708525/jobs/8394765063?pr=804#step:5:354)b831192db9091d97e9b4bc84231ade05d210

Footnotes

1. https://github.com/JuliaLang/PackageCompiler.jl/actions/runs/4730708525/jobs/8394765063?pr=804#step:5:197 ↩

[KristofferC]

JULIA_CPU_TARGETS are ignored while building sysimage 1.9-rc2

Is there an upstream issue regarding this?

[KristofferC]

The CI error seems relevant or?

ERROR: More than one command line CPU targets specified without a `--output-` flag specified
PackageCompiler.jl: Error During Test at /home/runner/work/PackageCompiler.jl/PackageCompiler.jl/test/runtests.jl:36

[ven-k]

• The ERROR: More than one command line CPU targets specified without a --output- flag specified : this comment and With 1.9.0-beta4, sysimages aren't built for the specified JULIA_CPU_TARGET #790 describe the issue.
• Fix imaging value for generating sysimages for multiple targets julia#48809 fixes that. But it isn't part of 1.9.0-rc2. Rn, it's enlisted here: Backports for 1.9.0 julia#49302. And backported with this commit JuliaLang/julia@9aa7669
• However, Fix imaging value for generating sysimages for multiple targets julia#48809 doesn't fix the failing case of JULIA_CPU_TARGET. See this comment.