Rename Pkg -> OldPkg, Pkg3 -> Pkg #27095

KristofferC · 2018-05-14T12:46:12Z

Also incorporates #26426. Right now, I have to point to a fork for Compat since this name changes breaks it: KristofferC/Compat.jl@01f178a

Fixes #26522

KristofferC · 2018-05-14T20:55:19Z

doc/src/manual/environment-variables.md


 ### `JULIA_PKGDIR`

-The path of the parent directory `Pkg.Dir._pkgroot()` for the version-specific


TODO: Remove these docs.

KristofferC · 2018-05-14T20:55:58Z

doc/src/manual/environment-variables.md


 A positive `Int` that determines how much time the max-sum subroutine
-`MaxSum.maxsum()` of the package dependency resolver `Pkg.resolve`
+`MaxSum.maxsum()` of the package dependency resolver `OldPkg.resolve`


Change to apply to Pkg.

KristofferC · 2018-05-15T12:44:09Z

stdlib/Pkg/src/Operations.jl

                success(pipeline(cmd, stdout=log, stderr=log))
            end ? Base.rm(log_file, force=true) :
-                @error("Error building `$name`; see log file for further info")
+                begin


Drop this commit, used for debugging.

StefanKarpinski

Looks good aside from a few minor issues I've commented on.

StefanKarpinski · 2018-05-15T17:59:52Z

base/loading.jl

        write(in, """
        begin
-        import Pkg
+        import OldPkg


Can we just delete this line now?

Not yet because OldPkg still puts, Pkg.dir (the function) into load path.

Ah, right. Deleting that is my job 😬...

StefanKarpinski · 2018-05-15T18:01:37Z

base/sysimg.jl

    @deprecate_binding Terminals       root_module(Base, :REPL).Terminals       true ", use `REPL.Terminals` instead"

    @deprecate_binding Pkg root_module(Base, :Pkg) true ", run `using Pkg` instead"
+    @deprecate_binding OldPkg root_module(Base, :OldPkg) true ", run `using OldPkg` instead"


This seems unlikely to happen, no? We can probably just skip this I would think.

StefanKarpinski · 2018-05-15T18:03:20Z

doc/src/manual/code-loading.md

 ## Federation of packages

-Julia supports federated management of packages. This means that multiple independent parties can maintain both public and private packages and registries of them, and that projects can depend on a mix of public and private packages from different registries. Packages from various registries are installed and managed using a common set of tools and workflows. The Pkg3 next-generation package manager [[docs](https://julialang.org/Pkg3.jl/latest/), [repo](https://github.com/JuliaLang/Pkg3.jl)] ships with Julia 0.7/1.0 and lets you install and manage dependencies of your projects, by creating and manipulating project files, which describe what your project depends on, and manifest files that snapshot exact versions of your project's complete dependency graph.
+Julia supports federated management of packages. This means that multiple independent parties can maintain both public and private packages and registries of them, and that projects can depend on a mix of public and private packages from different registries. Packages from various registries are installed and managed using a common set of tools and workflows. The Pkg next-generation package manager [[docs](https://julialang.org/Pkg.jl/latest/), [repo](https://github.com/JuliaLang/Pkg.jl)] ships with Julia 0.7/1.0 and lets you install and manage dependencies of your projects, by creating and manipulating project files, which describe what your project depends on, and manifest files that snapshot exact versions of your project's complete dependency graph.


I don't think you want to change these since these links are now broken. Unless you're planning on moving these repos?

I thought we would move the repo as well but can keep them until that has happened.

StefanKarpinski · 2018-05-15T18:07:33Z

stdlib/Pkg/bin/stdlib.toml

    "Mmap",
-    "Pkg",
+    "OldPkg",
+    "Pkg"


Missing trailing comma.

iagobaapellaniz · 2018-05-21T17:00:34Z

base/loading.jl

-then tries paths in the global array `LOAD_PATH`. `require` is case-sensitive on
-all platforms, including those with case-insensitive filesystems like macOS and
-Windows.
+When searching for files, `require` first looks for package code under  in the global array


... code under in the ...

Just use in. There are also 2 spaces after under.

Thanks, will fixup in a later PR.

mauro3 · 2018-05-24T08:15:10Z

stdlib/Pkg/src/Pkg.jl

+    global have_warned_session
+    have_warned_session && return
+    isinteractive() || return
+    if !PKG3_IS_PRECOMPILED && !haskey(ENV, "JULIA_PKG3_DISABLE_PRECOMPILE_WARNING")


Should these env. variables also be renamed to *_PKG_*? (Also, presumably the binaries will be compiled with this set, right?)

These are temporary and should be removed, see #27105

Details on the versions checks being used: JuliaLang/julia#25705 (544a5b8e39) => 0.7.0-DEV.3656 JuliaLang/julia#27095 (a209a45450) => 0.7.0-DEV.5183

KristofferC requested a review from StefanKarpinski May 14, 2018 12:46

KristofferC added the packages Package management and loading label May 14, 2018

KristofferC force-pushed the kc/ye_olde_pkg branch from 2bf76ac to 94e0aaa Compare May 14, 2018 13:38

KristofferC commented May 14, 2018

View reviewed changes

KristofferC force-pushed the kc/ye_olde_pkg branch 2 times, most recently from 089fcfc to 3738d99 Compare May 14, 2018 21:14

KristofferC commented May 15, 2018

View reviewed changes

StefanKarpinski requested changes May 15, 2018

View reviewed changes

Keno added this to the 1.0 milestone May 17, 2018

KristofferC mentioned this pull request May 17, 2018

update Compat for rename of Pkg to OldPkg JuliaLang/Compat.jl#547

Closed

KristofferC force-pushed the kc/ye_olde_pkg branch 3 times, most recently from 23aebec to 46c6738 Compare May 17, 2018 11:24

StefanKarpinski approved these changes May 18, 2018

View reviewed changes

KristofferC force-pushed the kc/ye_olde_pkg branch 3 times, most recently from a0e0009 to fc6b4b5 Compare May 21, 2018 12:42

iagobaapellaniz reviewed May 21, 2018

View reviewed changes

KristofferC force-pushed the kc/ye_olde_pkg branch from fc6b4b5 to 7f53bc0 Compare May 22, 2018 20:30

KristofferC mentioned this pull request May 23, 2018

update Compat for rename of Pkg to OldPkg JuliaLang/Compat.jl#551

Merged

KristofferC force-pushed the kc/ye_olde_pkg branch 2 times, most recently from f7ec774 to f009318 Compare May 23, 2018 07:36

KristofferC mentioned this pull request May 23, 2018

Log file for debugging problems JuliaLang/Pkg.jl#292

Closed

KristofferC force-pushed the kc/ye_olde_pkg branch from f009318 to 41f2046 Compare May 23, 2018 12:32

KristofferC added 5 commits May 23, 2018 16:58

rename Pkg to OldPkg

54feccd

rename Pkg3 to Pkg

fe80260

fix docstring for require to not mention Pkg.dir

6862a96

OldPkg -> Pkg where it makes sense

544eedf

use Pkg for docs

b44e40f

KristofferC added 10 commits May 23, 2018 16:58

remove OldPkg docs

9f06ace

fixup Pkg docs

e0eb01d

small fix for testing projects

453deca

fix files accidentally ignored in rename

ae864b9

small fixes from review

36e0516

remove link

457571c

add to NEWS

bd69803

fix bug making build not print

28c7483

fix bug in updating packages from git

acd112f

fix bugs in calling printpkgstyle

922f8f7

KristofferC force-pushed the kc/ye_olde_pkg branch from fca8a88 to 1270eda Compare May 23, 2018 14:58

KristofferC added 2 commits May 23, 2018 18:29

debug

652fd30

fix bug in instantiate

b017863

KristofferC force-pushed the kc/ye_olde_pkg branch from 1270eda to b017863 Compare May 23, 2018 16:30

StefanKarpinski merged commit a209a45 into master May 23, 2018

fredrikekre deleted the kc/ye_olde_pkg branch May 23, 2018 21:19

fredrikekre mentioned this pull request May 24, 2018

use Pkg3 for docs #26426

Closed

mauro3 reviewed May 24, 2018

View reviewed changes

Liozou pushed a commit to Liozou/julia that referenced this pull request May 24, 2018

Rename Pkg -> OldPkg, Pkg3 -> Pkg (JuliaLang#27095)

e4647c6

staticfloat mentioned this pull request May 24, 2018

Set JULIA_PKGDIR before Julia ever starts up when building docs #25036

Closed

omus added a commit to JuliaTesting/Mocking.jl that referenced this pull request Jun 27, 2018

Code review suggestions

e2bd9fa

Details on the versions checks being used: JuliaLang/julia#25705 (544a5b8e39) => 0.7.0-DEV.3656 JuliaLang/julia#27095 (a209a45450) => 0.7.0-DEV.5183

tpapp mentioned this pull request Dec 2, 2018

bring back package naming guidelines into the docs JuliaLang/Pkg.jl#945

Closed


		### `JULIA_PKGDIR`

		The path of the parent directory `Pkg.Dir._pkgroot()` for the version-specific

Uh oh!

Rename Pkg -> OldPkg, Pkg3 -> Pkg #27095

Rename Pkg -> OldPkg, Pkg3 -> Pkg #27095

Uh oh!

Conversation

KristofferC commented May 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanKarpinski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iagobaapellaniz May 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

KristofferC commented May 14, 2018 •

edited

Loading

iagobaapellaniz May 21, 2018 •

edited

Loading