-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
enable unconditional PKG3 precompile #27105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
5 greens, wat... |
|
@staticfloat is it possible to run the buildbots on this commit to try it out? |
|
Elliot is currently busy with his thesis. I will start a series of builds and let you know what the buildbots think about this.
|
|
Got an OOM on Win32 (https://build.julialang.org/#/builders/44/builds/1268), but only during |
|
Ok, so the only problem is the Win32 debug build. Seems a lot better than it was a while ago when half of CI crashed. |
|
Could we just disable it for debug builds? |
7dfe751 to
a7b0c54
Compare
|
Precompile statements should be a bit fewer now, rerunning CI and the buildbots. Linux 64: https://build.julialang.org/#/builders/43/builds/1304 |
|
Can't get e.g. Win32 to build, it just errors after building OpenBLAS with: |
a1a62f9 to
e2ea881
Compare
e2ea881 to
f82fcc9
Compare
|
The situation with Pkg3 without precompile statements are now (perhaps the new optimizer) fairly terrible. Just doing status takes up to 6-7 seconds and adding packages is almost back to Pkg2 coffee break times. I have yet managed to get a buildbot run through because it fails on random stuff that doesn't happen with the buildbots when running from master. So the only way to test this seems to be live. I have reduced the number of precompile statements here significantly going from this makes Pkg3 feel good, to this makes Pkg3 not feel like a slow moving piece of sloth. CircleCI fails because it is running on non rebased version of .circleci where the gcc version was not yet updated. |
Reopens #26431.
This needs to happen at some point so let's look at it again.