speed up resolve-scopes lowering pass #43022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
performance
vtjnash
approved these changes
Nov 10, 2021
Member
|
@Keno what type of tests do you want? Tests that the result is correct, or that the performance is good? |
Member
|
Tests that the performance is reasonable would be good. |
Member
|
Given that this is "only" a quadratic speedup, that test seems like it will be kind of brittle... Did you have something in mind? |
Member
|
If we can't reliably separate the fixed and broken cases using timing, I guess putting it on nanosolider would be reasonable. |
JeffBezanson
force-pushed
the
jb/faster-resolve-scopes
branch
from
0048aa8 to
0942542
Compare
JeffBezanson
added a commit
to JuliaCI/BaseBenchmarks.jl
that referenced
this pull request
Nov 16, 2021
Use a table to avoid each symbol lookup being O(n) in the scope nesting depth.
JeffBezanson
force-pushed
the
jb/faster-resolve-scopes
branch
from
0942542 to
4545fd2
Compare
Member
|
Is this good to merge now that we have a benchmark PR? |
vtjnash
pushed a commit
to JuliaCI/BaseBenchmarks.jl
that referenced
this pull request
Nov 16, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Use a table to avoid each symbol lookup being O(n) in the scope nesting depth.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Use a table to avoid each symbol lookup being O(n) in the scope nesting depth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a table to avoid each symbol lookup being O(n) in the scope nesting depth.
Usually scopes are not nested too deep, but our
letis actuallylet*, so each variable also introduces a new scope, so long lists of let-bound variables can be a problem.