speed up analyze-variables lowering pass by adding a hash table of variables
#43028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
compiler:lowering
oscardssmith
approved these changes
Nov 16, 2021
Member
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
oscardssmith
removed
the
merge me
Member
|
Should this have shown an improvement in the benchmark? |
Member
|
This was a significantly smaller change than the previous issue. It's likely that detecting it in the benchmark would have required way more let variables. IIRC, the use case that inspired this PR had something like 30K nested statements (compared to 2k for the benchmark). As such, I wouldn't be surprised if this change was considered to be within noise. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not as dramatic as #43022 but a bit of speedup nonetheless.