improve constraint propagation with && in ||
#43142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why we previously emitted an SSA value here. We only accept bools in if-conditions, so I don't see how `g` could be anything but `true` inside the first clause. fixes #43130
simeonschaub
added
compiler:inference
Member
|
In runtime, that is true, but at compile-time, true could be additionally refined to remain as a Conditional object. So I am surprised this works, but happy that it does, without needing to look any closer at how exactly this worked out. |
Member
Author
|
That should all happen way later though. I just meant lowering explicitly creating an ssavalue here and using that in both the condition and the body. |
DilumAluthge
removed
the
merge me
simeonschaub
added a commit
that referenced
this pull request
Dec 2, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
I don't know why we previously emitted an SSA value here. We only accept bools in if-conditions, so I don't see how `g` could be anything but `true` inside the first clause. fixes JuliaLang#43130
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…3142)" (JuliaLang#43293) This reverts commit 2c057f8.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
I don't know why we previously emitted an SSA value here. We only accept bools in if-conditions, so I don't see how `g` could be anything but `true` inside the first clause. fixes JuliaLang#43130
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…3142)" (JuliaLang#43293) This reverts commit 2c057f8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why we previously emitted an SSA value here. We only accept
bools in if-conditions, so I don't see how
gcould be anything buttrueinside the first clause.fixes #43130