Revert "improve constraint propagation with && in ||"
#43293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
added
regression
aviatesk
approved these changes
Dec 2, 2021
Member
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
When comparing !(a || b) (#43224) and !(a && b) (#43130), (a && b) || return can be manually transformed into a || return; b || return to get ideal inferrability, but (a || b) || return can't be transformed that way.
So for now we prefer the !(a || b) pattern to be functional.
We'd like to add some special case in frontend in the future so that it can generate constraint-propagatable code for !(a && b) pattern as we do for !(a || b).
DilumAluthge
removed
the
merge me
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…3142)" (JuliaLang#43293) This reverts commit 2c057f8.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…3142)" (JuliaLang#43293) This reverts commit 2c057f8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #43142
Unfortunately, this introduced regressions in some other cases, so let's revert that for now.
Fixes #43224