Skip to content

Conversation

@kpamnany
Copy link
Member

The previous awk pattern did not split out the 'build' portion of the version correctly. See details on semantic versions here.

The previous `awk` pattern did not split out the 'build' portion of the
version correctly.
@kpamnany kpamnany requested a review from staticfloat March 15, 2023 20:23
@staticfloat
Copy link
Member

How would we get a build version into here? You mean if someone has written e.g. 1.10.0-DEV+abc into their ./VERSION file?

@inkydragon inkydragon added the building Build system, or building Julia or its dependencies label Mar 16, 2023
@kpamnany
Copy link
Member Author

How would we get a build version into here? You mean if someone has written e.g. 1.10.0-DEV+abc into their ./VERSION file?

Right. We run a custom build of Julia with some things added as well as some backported features. This is one way in which we can determine whether we're running with our custom build or with stock Julia (checking VERSION.build).

@staticfloat
Copy link
Member

I see. Sure, seems reasonable enough!

@staticfloat staticfloat merged commit 551f303 into master Mar 16, 2023
@staticfloat staticfloat deleted the kp/fix-version branch March 16, 2023 15:20
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request May 1, 2023
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request May 12, 2023
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 7, 2023
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 22, 2023
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 29, 2023
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jul 6, 2023
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Aug 21, 2023
quinnj pushed a commit to RelationalAI/julia that referenced this pull request Sep 5, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Sep 28, 2023
Parse semantic version string correctly
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 1, 2023
Parse semantic version string correctly
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 12, 2023
Parse semantic version string correctly
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 14, 2023
Parse semantic version string correctly
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 17, 2023
Parse semantic version string correctly
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 18, 2023
Parse semantic version string correctly
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Oct 18, 2023
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Oct 19, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 20, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 23, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 1, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 2, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 7, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 10, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 14, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

building Build system, or building Julia or its dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants