- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.7k
Exclude 'build' from 'patch' in version parsing #49059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    So as to not break `ld` on Darwin.
| For clarity: if you actually add a 'build' element to  | 
              
                    staticfloat
  
              
              approved these changes
              
                  
                    Mar 20, 2023 
                  
              
              
            
            
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      May 1, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      May 12, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Jun 7, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Jun 22, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Jun 29, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Jul 6, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Aug 21, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  quinnj 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Sep 5, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Sep 28, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 1, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 12, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 14, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 17, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 18, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 18, 2023 
    
    
      
  
    
      
    
  
…ing-darwin Exclude 'build' from 'patch' in version parsing
    
  kpamnany 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 19, 2023 
    
    
  
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 20, 2023 
    
    
  
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Oct 23, 2023 
    
    
  
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Nov 1, 2023 
    
    
  
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Nov 2, 2023 
    
    
  
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Nov 7, 2023 
    
    
  
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Nov 10, 2023 
    
    
  
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Nov 14, 2023 
    
    
  
    
  DelveCI 
      pushed a commit
        to RelationalAI/julia
      that referenced
      this pull request
    
      Nov 15, 2023 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
So as to not break
ldon Darwin. Follow-up to #49018.