Skip to content

Conversation

@kpamnany
Copy link
Member

So as to not break ld on Darwin. Follow-up to #49018.

So as to not break `ld` on Darwin.
@kpamnany kpamnany requested a review from staticfloat March 20, 2023 12:49
@kpamnany
Copy link
Member Author

For clarity: if you actually add a 'build' element to VERSION, ld on Darwin will gripe that it cannot parse it properly ('build' should not be passed in as part of 'patch' in the -current_version command line argument here). This PR fixes that.

@staticfloat staticfloat merged commit 8b6f59f into master Mar 20, 2023
@staticfloat staticfloat deleted the kp/fix-version-parsing-darwin branch March 20, 2023 16:15
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request May 1, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request May 12, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 7, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 22, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 29, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jul 6, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Aug 21, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
quinnj pushed a commit to RelationalAI/julia that referenced this pull request Sep 5, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Sep 28, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 1, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 12, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 14, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 17, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 18, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Oct 18, 2023
…ing-darwin

Exclude 'build' from 'patch' in version parsing
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Oct 19, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 20, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 23, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 1, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 2, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 7, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 10, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 14, 2023
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants