Support Serializer for Nothing on the JS target #2330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elated tests `kotlinx.serialization.protobuf.ProtobufNothingTest#testNothing` currently fails on "jsLegacy" and I haven't succeeded in resolving this.
…ause generating serializers for parameterized types seems not to work on it
sandwwraith
requested changes
Jul 11, 2023
Member
sandwwraith
left a comment
sandwwraith
left a comment
There was a problem hiding this comment.
Hi! Thanks for the PR. Given that Kotlin ticket likely won't be fixed soon, it is OK to add this workaround after fixing minor issues.
core/commonTest/src/kotlinx/serialization/SerializersModuleTest.kt
Outdated
Show resolved
Hide resolved
formats/protobuf/commonTest/src/kotlinx/serialization/protobuf/ProtobufNothingTest.kt
Show resolved
Hide resolved
Co-authored-by: Leonid Startsev <[email protected]>
Contributor
Author
|
@sandwwraith Hi I have updated the tests. Please check if they are OK now. |
sandwwraith
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #932 (the JS target part)