-
Notifications
You must be signed in to change notification settings - Fork 666
Support Serializer for Nothing on the JS target #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
55d0167
Add support for serialization of `Nothing` on the JS target and add r…
ShreckYe 4319adb
Quit testing `ParameterizedBox<Nothing?>` on the JS legacy target bec…
ShreckYe 4b71561
Improve the tests for `Nothing` as suggested by @sandwwraith in #2330
ShreckYe f130545
Add a comment referring to the Kotlin issue as suggested by @sandwwraith
ShreckYe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
formats/protobuf/commonTest/src/kotlinx/serialization/protobuf/ProtobufNothingTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Copyright 2017-2023 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
| */ | ||
|
|
||
| package kotlinx.serialization.protobuf | ||
|
|
||
| import kotlinx.serialization.* | ||
| import kotlinx.serialization.test.* | ||
| import kotlin.test.* | ||
|
|
||
| class ProtobufNothingTest { | ||
| @Serializable | ||
| /*private*/ data class NullableNothingBox(val value: Nothing?) // `private` doesn't work on the JS legacy target | ||
ShreckYe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| @Serializable | ||
| private data class ParameterizedBox<T : Any>(val value: T?) | ||
|
|
||
| private inline fun <reified T> testConversion(data: T, expectedHexString: String) { | ||
| val string = ProtoBuf.encodeToHexString(data).uppercase() | ||
| assertEquals(expectedHexString, string) | ||
| assertEquals(data, ProtoBuf.decodeFromHexString(string)) | ||
| } | ||
|
|
||
| @Test | ||
| fun testNothing() { | ||
| testConversion(NullableNothingBox(null), "") | ||
| if (isJsLegacy()) return | ||
| testConversion(ParameterizedBox(null), "") | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.