Clicking Recommended copies values down! Closes #286

[shanselman]

Sorry, trying again. ;)

[ps2]

I just tried it out. I was surprised to see that clicking on the recommended value didn't do anything, then I noticed that the word "Recommended" was highlighted.

This may only be my opinion, but I feel it is more intuitive to tap on the actual value that you want to bolus, instead of the word "Recommended". I've seen other interfaces (trading interfaces where if you want to place an order at a price, you click on the price to auto fill in that part of your order) that use this interaction to good effect.

[shanselman]

I hear you @ps2 and I thought about that. I also thought about not using a Button/HyperLink control like I did, but from what I could find about Apple Design Guidelines this blue is the way it's usually done in their world (action links in blue, etc).

That said, if you feel strongly about it, I will look at overloading both and making the whole line take that action. Basically expanding the hit area. :)

[trixing]

What about simply prefilling it with the right value to begin with? It's not that the screen contains any information you could use to double check the calculated value is "correct".

…

On Thu, Dec 1, 2016 at 8:44 AM, Scott Hanselman ***@***.***> wrote: I hear you @ps2 <https://github.com/ps2> and I thought about that. I also thought about not using a Button/HyperLink control like I did, but from what I could find about Apple Design Guidelines this blue is the way it's usually done in their world (action links in blue, etc). That said, if you feel strongly about it, I will look at overloading *both* and making the whole line take that action. Basically expanding the hit area. :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#288 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE2alefVhrNwDoZu7wh_7HYg83tUrHzks5rDnrjgaJpZM4LA-HQ> .

-- Jan Dittmer <[email protected]>, http://l4x.org

[loudnate]

I agree with Pete that tapping on the number is most intuitive. I also don't think "Recommended" should have a button (blue) appearance, because "Recommended" It's not a verb and doesn't describe the action performed. If you ware to apply the HIG to this feature and make it available to users, you'd need a separate button titled "Apply" or "Copy"

The other approach is to see tapping (anywhere on the Recommended row) to apply the value as a "pro shortcut"; something that can be discovered and shared by power users. The appearance of the screen wouldn't change.

Whatever you need up with, don't forget to make it accessible!

[shanselman]

@trixing I think the thinking behind NOT filling it out by default is to avoid someone delivering blindly or without thought. Recommended is a tap away.

@loudnate Cool, I'll look at using the whole row without a visible button.

[shanselman]

Ok, @loudnate @ps2 that includes the "touch anywhere on the row" functionality as well as accessiblity for a custom action (with a description) for VoiceOver.

[trixing]

@shanselman my point is that the dialog offers no way to double check the recommended value. What I think would be useful is to show the current/predicted/minimum BG, the ISF, COB and IOB. That way at least you can double check the algorithm in this window.

Manually entering the number at least has a safety benefit of e.g. kids or unlocked phone in pocket not accidentally delivering insulin.

When it is just a tap away, I don't see any additional safety benefit over prefilling the value. You have to touch-id anyway to actually execute it.

What I think it should prevent without additional confirmation is to go over the recommended value.

[shanselman]

@trixing adding all the values from the main screen is another enhancement, a useful one perhaps, but outside the scope of my first little one here. Perhaps in another PR.