Skip to content

Clicking Recommended copies values down! Closes #286 #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2016
Merged

Clicking Recommended copies values down! Closes #286 #288

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5710778
Clicking Recommended copies values down! Closes #286
shanselman Dec 1, 2016
cc098c4
Reverting UI change to Bolus Wizard
shanselman Dec 1, 2016
2032250
VoiceOver/Accessibilty for Recommended Bolus ProUser trick
shanselman Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions Loop/View Controllers/BolusViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class BolusViewController: UITableViewController, IdentifiableClass, UITex
bolusAmountTextField.accessibilityHint = String(format: NSLocalizedString("Recommended Bolus: %@ Units", comment: "Accessibility hint describing recommended bolus units"), spellOutFormatter.string(from: NSNumber(value: recommendedBolus)) ?? "0")

bolusAmountTextField.becomeFirstResponder()

AnalyticsManager.sharedManager.didDisplayBolusScreen()
}

Expand All @@ -42,10 +42,30 @@ final class BolusViewController: UITableViewController, IdentifiableClass, UITex
}
}

override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
if (indexPath.row == 0) {
acceptRecommendedBolus();
}
}

override func tableView(_ tableView: UITableView, willDisplay cell: UITableViewCell, forRowAt indexPath: IndexPath) {
if (indexPath.row == 0) {
cell.accessibilityCustomActions = [
UIAccessibilityCustomAction(name: NSLocalizedString("AcceptRecommendedBolus", comment: "Action to copy the recommended Bolus value to the actual Bolus Field"), target: self, selector: #selector(BolusViewController.acceptRecommendedBolus))
]
}
}

@objc
func acceptRecommendedBolus() {
bolusAmountTextField?.text = recommendedBolusAmountLabel?.text
}


@IBOutlet weak var bolusAmountTextField: UITextField!

// MARK: - Actions

@IBAction func authenticateBolus(_ sender: Any) {
bolusAmountTextField.resignFirstResponder()

Expand Down