Skip to content

Conversation

yuxianq
Copy link
Collaborator

@yuxianq yuxianq commented May 20, 2025

No description provided.

@yuxianq
Copy link
Collaborator Author

yuxianq commented May 20, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5824 [ run ] triggered by Bot

Signed-off-by: Yuxian Qiu <[email protected]>
@yuxianq yuxianq force-pushed the deprecate-autopp branch from e46d596 to 1196bc0 Compare May 20, 2025 05:25
@yuxianq yuxianq changed the base branch from main to release/0.20 May 20, 2025 05:25
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 20, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5826 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5824 [ run ] completed with state ABORTED

Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Are there any other examples/docs that we need to add the deprecation warning as well?

Signed-off-by: Yuxian Qiu <[email protected]>
@yuxianq yuxianq requested a review from a team as a code owner May 21, 2025 04:17
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 21, 2025

Are there any other examples/docs that we need to add the deprecation warning as well?

@Superjomn I also add deprecation warning to docs. As for examples, they will give the deprecation warning once the user run it with autopp, so we don't have to modify them.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5826 [ run ] completed with state ABORTED

@yuxianq
Copy link
Collaborator Author

yuxianq commented May 21, 2025

/bot skip --comment "This PR only contains deprecation warning, all single-gpu tests and most multi-gpu tests are passed."

@yuxianq yuxianq enabled auto-merge (squash) May 21, 2025 05:38
@yuxianq yuxianq requested a review from litaotju May 21, 2025 05:38
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5967 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5967 [ skip ] completed with state SUCCESS
Skipping testing for commit 4e6515e

@yuxianq yuxianq merged commit ff0f37b into NVIDIA:release/0.20 May 21, 2025
3 checks passed
amirkl94 pushed a commit to amirkl94/TensorRT-LLM that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants