Skip to content

chore: Deprecate autopp. #4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

chore: Deprecate autopp. #4471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1196bc0
chore: Deprecate autopp.
yuxianq May 20, 2025
4e6515e
Address comment.
yuxianq May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/models/core/llama/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ trtllm-build --checkpoint_dir ./tllm_checkpoint_1gpu_fp16_wq \
--output_dir ./tmp/llama/7B/trt_engines/weight_only/1-gpu/ \
--gemm_plugin auto

# Build LLaMA 7B using 2-way auto parallelism.
# Build LLaMA 7B using 2-way auto parallelism (deprecated).
python convert_checkpoint.py --model_dir ./tmp/llama/7B/ \
--output_dir ./tllm_checkpoint_1gpu_fp16 \
--dtype float16
Expand Down
3 changes: 3 additions & 0 deletions tensorrt_llm/auto_parallel/auto_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ def check_dtype(tensor):


def auto_parallel(network: Network, config: AutoParallelConfig):
logger.warning(
"auto_parallel is deprecated, "
"please use explicit parallelism like tp_size/pp_size instead.")
debug_mode = config.debug_mode
memory_budget = config.get_cluster_info(
).memory_budget_per_device * 1024 * 1024 * 1024
Expand Down
14 changes: 11 additions & 3 deletions tensorrt_llm/llmapi/llm_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,11 +771,19 @@ class LlmArgs(BaseModel):
cp_config: Optional[dict] = Field(default_factory=dict,
description="Context parallel config.")

auto_parallel: bool = Field(default=False,
description="Enable auto parallel mode.")
auto_parallel: bool = Field(
default=False,
description="Enable auto parallel mode.",
deprecated=
"Use tensor_parallel_size/pipeline_parallel_size/xxx_parallel_size instead.",
)

auto_parallel_world_size: Optional[int] = Field(
default=None, description="The world size for auto parallel mode.")
default=None,
description="The world size for auto parallel mode.",
deprecated=
"Use tensor_parallel_size/pipeline_parallel_size/xxx_parallel_size instead.",
)

load_format: Literal['auto', 'dummy'] = Field(
default='auto',
Expand Down