-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Set missing env variable WORLD_SIZE temporarily for trainer init #4742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b36b7f to
ea34d29
Compare
|
/bot run |
|
PR_Github #6808 [ run ] triggered by Bot |
|
PR_Github #6808 [ run ] completed with state |
ea34d29 to
b1e51af
Compare
|
/bot run |
|
PR_Github #6849 [ run ] triggered by Bot |
|
PR_Github #6849 [ run ] completed with state |
7c8651e to
205529b
Compare
|
/bot run |
|
PR_Github #6894 [ run ] triggered by Bot |
|
/bot run |
|
PR_Github #6897 [ run ] triggered by Bot |
|
PR_Github #6894 [ run ] completed with state |
|
PR_Github #6897 [ run ] completed with state |
3af0ecf to
8fadfec
Compare
Signed-off-by: Balaram Buddharaju <[email protected]>
8fadfec to
a463b3d
Compare
|
/bot run |
|
PR_Github #7001 [ run ] triggered by Bot |
|
PR_Github #7001 [ run ] completed with state |
Description
This addresses https://nvbugspro.nvidia.com/bug/5301221.
Context
We use a trainer (
transformers.Trainer) while creating dummy Medusa and Eagle heads. During the trainer's init, looks like torch dist training is being called and it expects env variables such asWORLD_SIZE,MASTER_PORT,MASTER_ADDR,RANK.To deal with a peculiar issue in transformers library, we unset
WORLD_SIZEwhile running tests in specific cluster nodes causing this test to fail.Proposed solution
Set
WORLD_SIZEenv variable temporarily at trainer init if env variable is missing.Alternative
Skip the test when
WORLD_SIZEis not set.Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.