-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Skip dummy medusa/eagle tests when WORLD_SIZE env variable is missing #4786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Skip dummy medusa/eagle tests when WORLD_SIZE env variable is missing #4786
Conversation
82feaee
to
581fbb0
Compare
/bot run |
PR_Github #7008 [ run ] triggered by Bot |
PR_Github #7008 [ run ] completed with state |
/bot run |
PR_Github #7087 [ run ] triggered by Bot |
PR_Github #7087 [ run ] completed with state |
/bot run --disable-fail-fast |
PR_Github #7096 Bot args parsing error: usage: /bot [-h] |
PR_Github #7099 [ run ] triggered by Bot |
PR_Github #7099 [ run ] completed with state |
/bot skip --comment "Fail on an unknown error that's unrelated to the PR." |
PR_Github #7107 Bot args parsing error: Failed to parse bot args |
/bot skip --comment "Pipeline passes for related tests. The failure is on a known CI issue." |
PR_Github #7109 [ skip ] triggered by Bot |
PR_Github #7109 [ skip ] completed with state |
…ssing Signed-off-by: Balaram Buddharaju <[email protected]>
83aa855
to
0c51b3f
Compare
/bot run --disable-fail-fast |
PR_Github #7145 [ run ] triggered by Bot |
PR_Github #7145 [ run ] completed with state |
/bot skip --comment "Failing tests unrelated to incoming changes." |
PR_Github #7150 [ skip ] triggered by Bot |
PR_Github #7150 [ skip ] completed with state |
…ssing (NVIDIA#4786) Signed-off-by: Balaram Buddharaju <[email protected]>
Description
This addresses https://nvbugspro.nvidia.com/bug/5301221.
We unset
WORLD_SIZE
env variable while running tests in specific cluster nodes to deal with a bug in transformers library. Trainer initialization inget_dummy_spec_decoding_heads()
function fails ifWORLD_SIZE
is unset. Preemptively skip tests ifWORLD_SIZE
is unset.Alternative:
Setting
WORLD_SIZE
duringTrainer
's init (#4742) - I'm avoiding this as it could pollute the env.Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]
to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]
Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast
(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test
(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"
(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"
(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test
(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test
(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test
(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge
(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"
(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request.
--comment "Reason for skipping build/test"
is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.