-
Notifications
You must be signed in to change notification settings - Fork 1.8k
infra: [TRTLLM-5873] Use build stage wheels to speed up docker release image build #4939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: [TRTLLM-5873] Use build stage wheels to speed up docker release image build #4939
Conversation
/bot run --extra-stage "Build-Docker-Images" --skip-test |
PR_Github #7657 [ run ] triggered by Bot |
PR_Github #7657 [ run ] completed with state |
PR_Github #7663 [ run ] triggered by Bot |
PR_Github #7663 [ run ] completed with state |
PR_Github #7670 [ run ] triggered by Bot |
PR_Github #7670 [ run ] completed with state |
PR_Github #7672 [ run ] triggered by Bot |
PR_Github #7674 [ run ] triggered by Bot |
PR_Github #7672 [ run ] completed with state |
PR_Github #7681 [ run ] triggered by Bot |
PR_Github #7674 [ run ] completed with state |
PR_Github #7695 [ run ] triggered by Bot |
PR_Github #7681 [ run ] completed with state |
PR_Github #7695 [ run ] completed with state |
PR_Github #7703 [ run ] triggered by Bot |
PR_Github #7703 [ run ] completed with state |
PR_Github #7710 [ run ] triggered by Bot |
PR_Github #7714 [ run ] triggered by Bot |
PR_Github #7710 [ run ] completed with state |
PR_Github #7716 [ run ] triggered by Bot |
PR_Github #7714 [ run ] completed with state |
PR_Github #7717 [ run ] triggered by Bot |
PR_Github #7716 [ run ] completed with state |
PR_Github #7722 [ run ] triggered by Bot |
PR_Github #7717 [ run ] completed with state |
PR_Github #7722 [ run ] completed with state |
PR_Github #7724 [ run ] triggered by Bot |
PR_Github #7729 [ run ] triggered by Bot |
PR_Github #7724 [ run ] completed with state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🧹 Nitpick comments (1)
scripts/get_wheel_from_package.py (1)
30-44
: Consider adding architecture validationThe argument parsing should validate the architecture parameter to ensure it's supported.
def add_arguments(parser: ArgumentParser): parser.add_argument("--arch", "-a", required=True, + choices=["x86_64", "aarch64", "arm64"], help="Architecture to build for")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docker/Dockerfile.multi
(1 hunks)docker/Makefile
(2 hunks)jenkins/Build.groovy
(1 hunks)jenkins/BuildDockerImage.groovy
(5 hunks)scripts/get_wheel_from_package.py
(1 hunks)
🔇 Additional comments (10)
jenkins/Build.groovy (1)
447-447
: LGTM: Consistent benchmark packagingThe addition of
disaggServerBenchmark
follows the established pattern for copying benchmark executables and maintains consistency with the other benchmark files being packaged.docker/Makefile (2)
42-42
: LGTM: Clean variable declarationThe
BUILD_WHEEL_SCRIPT
variable with empty default value provides flexibility for configuring the wheel build script path.
84-84
: LGTM: Proper conditional build argumentThe conditional passing of
BUILD_WHEEL_SCRIPT
as a build argument follows the established pattern and only adds the argument when the variable is set, avoiding unnecessary build arguments.docker/Dockerfile.multi (2)
131-131
: LGTM: Configurable build script with sensible defaultThe
BUILD_WHEEL_SCRIPT
argument with default value"scripts/build_wheel.py"
maintains backward compatibility while enabling customization for the wheel build optimization.
133-133
: LGTM: Proper variable substitutionThe use of
${BUILD_WHEEL_SCRIPT}
variable instead of hardcoded path enables the configurable wheel build script functionality.jenkins/BuildDockerImage.groovy (5)
28-30
: LGTM: Clear variable declarationsThe
TRIGGER_TYPE
variable with sensible default and theWAIT_TIME_FOR_BUILD_STAGE
constant are well-defined and improve code readability.
190-209
: LGTM: Well-structured wheel preparation functionThe
prepareWheelFromBuildStage
function has good validation logic and clear conditional returns. The parameter validation and early returns for non-applicable scenarios are appropriate.
232-232
: LGTM: Consistent variable usageThe change from
params.triggerType
toTRIGGER_TYPE
ensures consistency with the centralized variable definition.
297-297
: LGTM: Clean integration of wheel preparationThe integration of
prepareWheelFromBuildStage
into the build arguments is clean and maintains the existing argument building pattern.
442-442
: LGTM: Improved error handling structureMoving the echo statement inside the
catchError
block improves the error handling flow and ensures proper logging during failures.
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
0c9ebd6
to
56389f2
Compare
Signed-off-by: ZhanruiSunCh <[email protected]>
/bot run |
PR_Github #13112 [ run ] triggered by Bot |
PR_Github #13112 [ run ] completed with state |
/bot run |
PR_Github #13311 [ run ] triggered by Bot |
PR_Github #13311 [ run ] completed with state |
…e image build (NVIDIA#4939) Signed-off-by: ZhanruiSunCh <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
…e image build (NVIDIA#4939) Signed-off-by: ZhanruiSunCh <[email protected]>
Summary by CodeRabbit
New Features
Chores