[None][infra] Add build configs for tritonrelease #7096
Conversation
📝 WalkthroughWalkthroughAdds two tritonrelease build matrix entries (x86_64 and SBSA) to the Jenkins pipeline and extends the wheel-build OOM mitigation and node selection logic that previously applied to "trtllm" to also apply to "tritonrelease". Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant J as Jenkins Pipeline
participant BM as Build Matrix
participant Node as Build Node (x86_64 / SBSA)
participant D as Docker Builder
participant W as Wheel Builder
Dev->>J: Trigger pipeline
J->>BM: Expand matrix
note over BM: matrix includes trtllm and tritonrelease (x86_64, SBSA)
BM-->>J: Selected job (target, arch, tags, stage)
J->>J: Evaluate OOM mitigation (applies to trtllm and tritonrelease)
J->>Node: Select node by arch
Node->>D: Build Docker image (stage = tritonrelease | trtllm)
alt build_wheel == true
D->>W: Build wheel inside image
W-->>J: Return artifacts/status
end
J-->>Dev: Pipeline result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
dbari
force-pushed
the
feature/add-tritonrelease-builds
branch
from
3cc5182 to
c3c0a43
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
jenkins/BuildDockerImage.groovy (1)
318-324: OOM-mitigation now applies to tritonrelease; consider guarding by build_wheel and verify job-count valuesGood call extending this to tritonrelease. Two minor follow-ups:
- Gate this branch on config.build_wheel to avoid unintentionally overriding parallelism for non-wheel builds.
- BUILD_JOBS_RELEASE_X86_64 and BUILD_JOBS_RELEASE_SBSA are both set to "32", same as BUILD_JOBS. As written, this branch is currently a no-op. Confirm if reduced job counts were intended.
Apply this small guard to keep the behavior tightly scoped:
- if (target == "trtllm" || target == "tritonrelease") { + if (config.build_wheel && (target == "trtllm" || target == "tritonrelease")) { if (arch == "x86_64") { build_jobs = BUILD_JOBS_RELEASE_X86_64 } else { build_jobs = BUILD_JOBS_RELEASE_SBSA } }If the intent was to actually lower concurrency for release wheel builds, adjust BUILD_JOBS_RELEASE_* accordingly (e.g., "8" or "16").
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
jenkins/BuildDockerImage.groovy(2 hunks)
🔇 Additional comments (1)
jenkins/BuildDockerImage.groovy (1)
403-417: Makefile pattern rules and Dockerfile stage for tritonrelease are present; no changes needed
- docker/Makefile defines a
tritonrelease_%pattern (lines 172–174) and generic%_build/%_pushrules that covertritonrelease_buildandtritonrelease_push.- docker/Dockerfile.multi includes
FROM release AS tritonrelease(line 183).The new Jenkins entries will schedule the correct build/push targets and reuse the
tritonreleasestage as expected.
|
PR_Github #15929 [ run ] triggered by Bot |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
jenkins/BuildDockerImage.groovy (2)
318-324: Future-proof the OOM-mitigation by gating on intent (build_wheel) instead of enumerating targets.This keeps the logic correct for tritonrelease today and avoids having to touch this block when future wheel-building targets are added.
Apply this diff:
- if (target == "trtllm" || target == "tritonrelease") { + if (config.build_wheel) { if (arch == "x86_64") { build_jobs = BUILD_JOBS_RELEASE_X86_64 } else { build_jobs = BUILD_JOBS_RELEASE_SBSA } }
403-417: Confirm intent: wheel reuse from build stage is disabled for tritonrelease.
prepareWheelFromBuildStageonly acts fordockerfileStage == "release", so the newtritonreleaseconfigs won’t reuse wheels from a prior build-stage even ifuseWheelFromBuildStage=true. If you meant to enable reuse for tritonrelease as well, extend the allowlist.Proposed adjustment in
prepareWheelFromBuildStage(outside this hunk):// Treat tritonrelease as release-like for wheel reuse def releaseStages = ["release", "tritonrelease"] if (!releaseStages.contains(dockerfileStage)) { echo "prepareWheelFromBuildStage: ${dockerfileStage} is not release-like" return "" }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
jenkins/BuildDockerImage.groovy(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
jenkins/BuildDockerImage.groovy (2)
403-417: LGTM: New tritonrelease build configurations are consistent with existing patterns.
- Correctly mirrors the trtllm release entries for x86_64 and SBSA.
build_wheel: trueensures the arm64 node-affinity workaround kicks in for SBSA.
403-417: tritonrelease targets present in Makefile and Dockerfile.multi
- docker/Makefile includes a
tritonrelease_%pattern rule (lines 172–174)- Dockerfile.multi defines a
FROM release AS tritonreleasestage (line 183)- Note:
BUILD_WHEEL_OPTSisn’t referenced in thetritonreleasetargets; confirm whether that’s intentional or if support needs to be added.
|
PR_Github #15929 [ run ] completed with state |
dbari
force-pushed
the
feature/add-tritonrelease-builds
branch
from
c3c0a43 to
c96ca99
Compare
|
/bot run --skip-test --extra-stage "Build-Docker-Images" |
|
PR_Github #17327 [ run ] triggered by Bot |
|
PR_Github #17327 [ run ] completed with state |
|
/bot run --skip-test --extra-stage "Build-Docker-Images" |
|
PR_Github #17757 [ run ] triggered by Bot |
|
PR_Github #17757 [ run ] completed with state |
Signed-off-by: Dimitrios Bariamis <[email protected]>
dbari
force-pushed
the
feature/add-tritonrelease-builds
branch
from
c96ca99 to
3f807fe
Compare
|
@ZhanruiSunCh this PR is as we had talked about a few weeks ago. I can't start a run now, but it should work as shown by the last run (failed only due to unrelated issue). I'll start a run as soon as the CI is available. |
2 participants
Summary by CodeRabbit
New Features
Bug Fixes
Description
This PR adds build configurations for building and uploading the
tritonreleaseimage forx86_64andSBSAin post-merge.Attention: Building
tritonreleaseis currently broken, will be fixed after a343e85 is merged fromrelease/1.0tomainduring mass integration.Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.