fix: Ensure mlx5 library is installed for deep_ep and remove deprecated python bindings

[MartinMarciniszyn]

Summary by CodeRabbit

• New Features

  • Added a new build option to enable or disable the Deep EP module.
  • Enforced a mandatory check for the required mlx5 library during the build process.

• Chores

  • Removed the deprecated option to build Python bindings from the build script and Dockerfile, simplifying the build process.

[coderabbitai]

Walkthrough

A new CMake build option for the Deep EP module was introduced, and the build now enforces the presence of the mlx5 library. The Docker build process was modified to exclude Python bindings from wheel builds. Additionally, the Python build script was simplified by removing the deprecated Python bindings option and its related code.

Changes

File(s)	Change Summary
cpp/CMakeLists.txt	Added BUILD_DEEP_EP CMake option to control Deep EP module build.
cpp/tensorrt_llm/deep_ep/CMakeLists.txt	Enforced mandatory presence of mlx5 library using find_library(... REQUIRED).
docker/Dockerfile.multi	Removed --python_bindings from BUILD_WHEEL_ARGS, disabling Python bindings in wheel build.
scripts/build_wheel.py	Removed python_bindings parameter and deprecated CLI argument from build script.

Poem

A toggle for Deep EP, now in the build,
And mlx5 checks, so errors are stilled.
Python bindings left behind,
The wheel is lighter, streamlined!
With scripts now neat and tidy too,
This bunny hops to something new. 🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07e8813 and 5e58a39.

📒 Files selected for processing (4)

• cpp/CMakeLists.txt (1 hunks)
• cpp/tensorrt_llm/deep_ep/CMakeLists.txt (1 hunks)
• docker/Dockerfile.multi (1 hunks)
• scripts/build_wheel.py (0 hunks)

💤 Files with no reviewable changes (1)

• scripts/build_wheel.py

🔇 Additional comments (3)

cpp/CMakeLists.txt (1)

33-34: BUILD_DEEP_EP option is added but never referenced further down the file
A toggle is only useful if it is consumed (e.g. if(BUILD_DEEP_EP) add_subdirectory(tensorrt_llm/deep_ep) …). Please double-check that the flag is actually wired up, either here or in a downstream CMakeLists.txt; otherwise users cannot disable the Deep EP build to shorten CI time.

cpp/tensorrt_llm/deep_ep/CMakeLists.txt (1)

39-41: Library presence is checked but never linked – risk of unresolved symbols at link/run time
find_library(MLX5_lib NAMES mlx5 REQUIRED) guarantees the file exists, yet MLX5_lib is never passed to target_link_libraries.
If Deep EP or nvshmem requires symbols from libmlx5.so at link-time, the build will fail later; if it is dl-opened at run-time, this extra check is redundant. Please confirm the intent and either

target_link_libraries(deep_ep_cpp_tllm PRIVATE ${MLX5_lib})

or drop the REQUIRED check.

docker/Dockerfile.multi (1)

130-131: Removal of --python_bindings flag looks correct
The wheel build arguments now reflect the deprecation of the Python bindings path. 👍

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[MartinMarciniszyn]

/bot run --skip-tests

[tensorrt-cicd]

PR_Github #12328 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: --skip-tests

[MartinMarciniszyn]

/bot run --skip-test

[tensorrt-cicd]

PR_Github #12331 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #12331 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9161 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

[kaiyux]

LGTM

[kaiyux]

/bot skip --comment "no need for full testing"

[tensorrt-cicd]

PR_Github #12369 [ skip ] triggered by Bot

[tensorrt-cicd]

PR_Github #12369 [ skip ] completed with state SUCCESS
Skipping testing for commit 5e58a39