Skip to content

fix: Ensure mlx5 library is installed for deep_ep and remove deprecated python bindings #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025
Merged

fix: Ensure mlx5 library is installed for deep_ep and remove deprecated python bindings #6189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ project(tensorrt_llm LANGUAGES CXX)
option(BUILD_PYT "Build in PyTorch TorchScript class mode" ON)
option(BUILD_TESTS "Build Google tests" ON)
option(BUILD_BENCHMARKS "Build benchmarks" ON)
option(BUILD_DEEP_EP "Build the Deep EP module" ON)
option(BUILD_MICRO_BENCHMARKS "Build C++ micro benchmarks" OFF)
option(NVTX_DISABLE "Disable all NVTX features" ON)
option(WARNING_IS_ERROR "Treat all warnings as errors" OFF)
Expand Down
3 changes: 3 additions & 0 deletions cpp/tensorrt_llm/deep_ep/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ if(NOT DEEP_EP_CUDA_ARCHITECTURES)
return()
endif()

# Ensure that dependent libraries are installed
find_library(MLX5_lib NAMES mlx5 REQUIRED)

# Prepare files
# =============

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.multi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ RUN mkdir -p /root/.cache/pip /root/.cache/ccache
ENV CCACHE_DIR=/root/.cache/ccache
# Build the TRT-LLM wheel
ARG GITHUB_MIRROR=""
ARG BUILD_WHEEL_ARGS="--clean --python_bindings --benchmarks"
ARG BUILD_WHEEL_ARGS="--clean --benchmarks"
RUN --mount=type=cache,target=/root/.cache/pip --mount=type=cache,target=${CCACHE_DIR} \
GITHUB_MIRROR=$GITHUB_MIRROR python3 scripts/build_wheel.py ${BUILD_WHEEL_ARGS}

Expand Down
6 changes: 0 additions & 6 deletions scripts/build_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ def main(*,
install: bool = False,
skip_building_wheel: bool = False,
linking_install_binary: bool = False,
python_bindings: bool = True,
binding_type: str = "pybind",
benchmarks: bool = False,
micro_benchmarks: bool = False,
Expand Down Expand Up @@ -860,11 +859,6 @@ def add_arguments(parser: ArgumentParser):
"--linking_install_binary",
action="store_true",
help="Install the built binary by symbolic linking instead of copying.")
parser.add_argument(
"--python_bindings",
"-p",
action="store_true",
help="(deprecated) Build the python bindings for the C++ runtime.")
parser.add_argument("--binding_type",
choices=["pybind", "nanobind"],
default="pybind",
Expand Down