Skip to content

Conversation

@Tabrizian
Copy link
Member

@Tabrizian Tabrizian commented Aug 14, 2025

Summary by CodeRabbit

  • Chores
    • Updated multi-stage container build to include additional build scripts and configuration in the build stage so required assets are present during image compilation.
    • Improves CI and local build reliability, reducing failures from missing build assets and simplifying troubleshooting.
    • No changes to runtime behavior or public APIs; no user action required.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Tabrizian Tabrizian requested review from a team as code owners August 14, 2025 07:47
@Tabrizian Tabrizian requested review from Shixiaowei02 and kxdc August 14, 2025 07:47
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 14, 2025

📝 Walkthrough

Walkthrough

Adds two COPY commands to the tritonbuild stage in docker/Dockerfile.multi to include jenkins/scripts/get_triton_tag.sh and the repository docker/Dockerfile.multi file into the image before running the existing triton_backend/inflight_batcher_llm/scripts/build.sh; no other commands changed.

Changes

Cohort / File(s) Change Summary
Docker build context updates
docker/Dockerfile.multi
Added two COPY steps in the tritonbuild stage to copy jenkins/scripts/get_triton_tag.sh and docker/Dockerfile.multi into the image prior to executing triton_backend/inflight_batcher_llm/scripts/build.sh.

Sequence Diagram(s)

sequenceDiagram
    participant Host as Host filesystem
    participant Docker as Docker build (tritonbuild stage)
    participant Image as Triton image filesystem

    Host->>Docker: Build context includes files
    Docker->>Image: COPY jenkins/scripts/get_triton_tag.sh -> ./jenkins/scripts/get_triton_tag.sh
    Docker->>Image: COPY docker/Dockerfile.multi -> ./docker/Dockerfile.multi
    Docker->>Image: RUN bash ./triton_backend/inflight_batcher_llm/scripts/build.sh
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • chzblych
  • SimengLiu-nv

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c09f3cd and 28c1008.

📒 Files selected for processing (1)
  • docker/Dockerfile.multi (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docker/Dockerfile.multi
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Tabrizian
Copy link
Member Author

/bot run

@Tabrizian Tabrizian changed the title Fix triton docker build [https://nvbugs/5451434][fix] Fix triton docker build Aug 14, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docker/Dockerfile.multi (2)

179-180: Ensure script executability and build-context availability.

  • If build.sh execs get_triton_tag.sh directly (not via bash), this may fail if the script lacks +x in the repo. Prefer setting permissions during COPY.
  • Confirm that .dockerignore does not exclude jenkins/ or docker/; otherwise these COPY steps will fail in CI.

Suggested change to harden permissions:

-COPY ./jenkins/scripts/get_triton_tag.sh ./jenkins/scripts/get_triton_tag.sh
+COPY --chmod=0755 ./jenkins/scripts/get_triton_tag.sh ./jenkins/scripts/get_triton_tag.sh

Alternatively, ensure build.sh invokes it as bash ./jenkins/scripts/get_triton_tag.sh.


179-181: Optional: avoid copying the Dockerfile into the image by parameterizing build.sh.

If build.sh (or get_triton_tag.sh) supports consuming TRITON_BASE_TAG from env/arg, you can remove the Dockerfile COPY and pass the value directly, reducing layer churn and avoiding an unusual pattern of copying the Dockerfile into the image:

-COPY ./docker/Dockerfile.multi ./docker/Dockerfile.multi
-RUN bash ./triton_backend/inflight_batcher_llm/scripts/build.sh
+RUN TRITON_BASE_TAG=${TRITON_BASE_TAG} bash ./triton_backend/inflight_batcher_llm/scripts/build.sh

Only adopt this if the scripts support reading TRITON_BASE_TAG (or you can update them accordingly).

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ebb770 and 2789be5.

📒 Files selected for processing (1)
  • docker/Dockerfile.multi (1 hunks)
🔇 Additional comments (1)
docker/Dockerfile.multi (1)

179-181: Good fix: include missing build inputs in tritonbuild stage.

Copying get_triton_tag.sh and the Dockerfile into the tritonbuild context explains frequent build failures where the script expects these files. Placement under /src/tensorrt_llm/* matches the WORKDIR, so build.sh should now locate them.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #15259 [ run ] triggered by Bot

@Tabrizian Tabrizian force-pushed the user/imant/fixTritonBuild branch from 2789be5 to c09f3cd Compare August 14, 2025 20:55
@Tabrizian
Copy link
Member Author

/bot run

@Tabrizian Tabrizian requested a review from chzblych August 14, 2025 20:56
@tensorrt-cicd
Copy link
Collaborator

PR_Github #15342 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #15342 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #124 completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot skip --comment "this docker command doesn't have CI coverage, verified locally"

Signed-off-by: Iman Tabrizian <[email protected]>
@Tabrizian Tabrizian force-pushed the user/imant/fixTritonBuild branch from c09f3cd to 28c1008 Compare August 15, 2025 03:23
@tensorrt-cicd
Copy link
Collaborator

PR_Github #15386 Bot args parsing error: Failed to parse bot args

@chzblych
Copy link
Collaborator

/bot skip --comment "this docker command does not have CI coverage and verified locally"

@chzblych chzblych enabled auto-merge (squash) August 15, 2025 05:45
@tensorrt-cicd
Copy link
Collaborator

PR_Github #15405 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #15405 [ skip ] completed with state SUCCESS
Skipping testing for commit 28c1008

@chzblych chzblych merged commit 96be46f into NVIDIA:release/1.0 Aug 15, 2025
5 checks passed
@Tabrizian Tabrizian deleted the user/imant/fixTritonBuild branch August 15, 2025 16:20
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 22, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 22, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 22, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 23, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 24, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 25, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 25, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 25, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 26, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 27, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 27, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 27, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 27, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 28, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 28, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 28, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 28, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 28, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 28, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 29, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 29, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 29, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 29, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 29, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 30, 2025
joyang-nv pushed a commit that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants