[https://nvbugs/5474037][fix] Fix building tritonbuild/tritonrelease images

[dbari]

Summary by CodeRabbit

• Chores
  • Made Docker build more configurable by introducing a build-time argument for the Triton base image tag in the multi-stage build. This enables easier alignment with different Triton base versions across environments and simplifies backend image customization. No impact on runtime behavior or user-facing functionality; change is limited to build-time configuration.

Description

Make TRITON_BASE_TAG visible in tritonbuild stage

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a build argument TRITON_BASE_TAG to the tritonbuild stage in docker/Dockerfile.multi and passes its “-py3”-stripped value to the inflight_batcher_llm build script. No other changes.

Changes

Cohort / File(s)	Summary
Docker build parameterization docker/Dockerfile.multi	Introduces ARG TRITON_BASE_TAG in tritonbuild stage and uses ${TRITON_BASE_TAG%-py3} when invoking the inflight_batcher_llm build script to parameterize the Triton base tag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [None][fix] Fix build of tritonbuild/tritonrelease image #7003 — Also parameterizes/passes TRITON_BASE_TAG (stripping “-py3”) to inflight_batcher_llm in docker/Dockerfile.multi.
• [https://nvbugs/5451434][fix] Fix triton docker build #6898 — Adjusts tritonbuild stage to support inflight_batcher_llm backend build by ensuring scripts/Dockerfile are present.
• [https://nvbugs/5444624][fix] Fix LLM_ROOT in triton_backend build.sh #6744 — Changes inflight_batcher_llm build flow by fixing LLM_ROOT in build.sh; complementary to adding TRITON_BASE_TAG usage.

Suggested reviewers

• rakib-hasan
• syuoni
• kaiyux
• SimengLiu-nv
• schetlur-nv
• liji-nv
• Shixiaowei02
• brb-nv
• nv-yilinf

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

docker/Dockerfile.multi (1)

179-180: Optional: Validate TRITON_BASE_TAG before using it to catch typos early.

A lightweight guard can make failures easier to diagnose if a bad tag is passed (e.g., “foo”); otherwise the backend build script may fail later with a less obvious error.

Apply this minimal inline check:

-ARG TRITON_BASE_TAG
-RUN bash ./triton_backend/inflight_batcher_llm/scripts/build.sh -s "r${TRITON_BASE_TAG%-py3}"
+ARG TRITON_BASE_TAG
+RUN tag="${TRITON_BASE_TAG}" && \
+    case "$tag" in *py3|*py3-*|*py3.*) : ;; *) : ;; esac && \
+    bash ./triton_backend/inflight_batcher_llm/scripts/build.sh -s "r${tag%-py3}"

Note: The case is permissive; it won’t block unusual tags but keeps the logic explicit and reuses the computed tag variable.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 253af9f and c95ce9b.

📒 Files selected for processing (1)

• docker/Dockerfile.multi (1 hunks)

🔇 Additional comments (2)

docker/Dockerfile.multi (2)

179-180: Correctly re-declaring ARG in-stage; suffix trim usage looks right.

Re-declaring TRITON_BASE_TAG in the tritonbuild stage is necessary for availability within RUN. The bash/dash parameter expansion ${TRITON_BASE_TAG%-py3} safely strips a trailing “-py3” when present and leaves the tag unchanged otherwise. Quoting the -s value avoids word-splitting issues. LGTM.

---

179-180: ✅ Confirmed: Build script expects -s with ‘rYY.MM’

The build.sh script only accepts the short -s flag and its help text clearly states it expects a Triton tag of the form rYY.MM (e.g. r25.06). The Dockerfile invocation

ARG TRITON_BASE_TAG
RUN bash ./triton_backend/inflight_batcher_llm/scripts/build.sh -s "r${TRITON_BASE_TAG%-py3}"

strips -py3 (e.g. 25.06) and prepends r, producing exactly r25.06, which matches the expected format. No changes required here.

[dbari]

@StanleySun639 @yuxianq this should fix the problem, I am now building the complete image locally to make sure it works and will post confirmation. I am only wondering how I managed to build the image locally without this before, I suspect a docker caching issue.

[dbari]

/bot run --skip-test

[tensorrt-cicd]

PR_Github #16179 [ run ] triggered by Bot

[dbari]

@StanleySun639 @yuxianq this should fix the problem, I am now building the complete image locally to make sure it works and will post confirmation.

I can confirm that the local build is successful.

[tensorrt-cicd]

PR_Github #16179 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #264 (Partly Tested) completed with status: 'SUCCESS'