-
Couldn't load subscription status.
- Fork 1.8k
[None][chore] Add failed cases into waives.txt #7986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[None][chore] Add failed cases into waives.txt #7986
Conversation
📝 WalkthroughWalkthroughAdded four SKIP waivers to tests/integration/test_lists/waives.txt for specific FP8 accuracy tests in test_llm_api_pytorch.py across L20 and L40S configurations, citing nvbugs. No code or public API changes. Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings📚 Learning: 2025-09-17T02:48:52.732ZApplied to files:
📚 Learning: 2025-08-29T14:07:45.863ZApplied to files:
📚 Learning: 2025-07-28T17:06:08.621ZApplied to files:
🔇 Additional comments (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
af95895 to
3632bf4
Compare
|
/bot run --skip-test |
|
PR_Github #20022 [ run ] triggered by Bot |
|
PR_Github #20022 [ run ] completed with state |
39db033 to
b173582
Compare
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
b173582 to
3637f42
Compare
|
/bot reuse-pipeline |
|
PR_Github #20049 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #20049 [ reuse-pipeline ] completed with state |
waive failed cases.
Summary by CodeRabbit