Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Sep 25, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated waived tests list to skip four FP8 accuracy scenarios across multiple configurations, aligned with known tracked issues. This reduces CI noise by avoiding unstable cases.
  • Chores
    • Test maintenance to improve reliability and signal quality during continuous integration.
  • No User-Facing Changes
    • No impact on application features, behavior, performance, or APIs.

@xinhe-nv xinhe-nv marked this pull request as ready for review September 26, 2025 02:10
@xinhe-nv xinhe-nv enabled auto-merge (squash) September 26, 2025 02:10
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 26, 2025

📝 Walkthrough

Walkthrough

Added four SKIP waivers to tests/integration/test_lists/waives.txt for specific FP8 accuracy tests in test_llm_api_pytorch.py across L20 and L40S configurations, citing nvbugs. No code or public API changes.

Changes

Cohort / File(s) Summary
Test waivers update
tests/integration/test_lists/waives.txt
Added 4 SKIP entries: L20/L40S variants for TestLlama3_2_1B::test_fp8_prequantized and TestMinistral8BInstruct::test_fp8, referencing nvbugs.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is overly brief and does not follow the repository’s required template because it lacks a descriptive summary, a Test Coverage section, and the PR Checklist, making it insufficiently informative. Please update the PR description to follow the provided template by adding a detailed Description section outlining the changes and rationale, a Test Coverage section listing relevant tests, and a completed PR Checklist.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title uses the correct ticket and type format and clearly summarizes the main change of adding failed test cases to waives.txt without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 259cc66 and 7d69659.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

353-356: Waivers correctly scoped to affected FP8 tests.

No conflicts spotted with existing entries and the nvbugs reference is consistent with house style. Thanks for documenting both L20 and L40S variants.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1396 branch 2 times, most recently from af95895 to 3632bf4 Compare September 26, 2025 02:17
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20022 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20022 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15081 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1396 branch 2 times, most recently from 39db033 to b173582 Compare September 26, 2025 05:11
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1396 branch from b173582 to 3637f42 Compare September 26, 2025 06:24
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20049 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20049 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #20022 (Partly Tested) for commit 3637f42

@xinhe-nv xinhe-nv merged commit f32f573 into NVIDIA:main Sep 26, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1396 branch September 26, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants