Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Oct 21, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip list to mark a specific test configuration as skipped due to a known issue.

@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Oct 22, 2025
@xinhe-nv xinhe-nv marked this pull request as ready for review October 22, 2025 01:49
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251022_LLM_FUNCTION_TEST_1535 branch from 5c5247a to 3219143 Compare October 22, 2025 01:49
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

📝 Walkthrough

Walkthrough

Adds a single test entry to the skip list in tests/integration/test_lists/waives.txt for examples/test_phi.py::test_phi_fp8_with_bf16_lora[Phi-3.5-MoE-instruct] with SKIP status due to nvbugs/5465143.

Changes

Cohort / File(s) Change Summary
Test Skip List Update
tests/integration/test_lists/waives.txt
Added one test entry to skip list: examples/test_phi.py::test_phi_fp8_with_bf16_lora[Phi-3.5-MoE-instruct] marked as SKIP for nvbugs/5465143

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description consists only of "waive failed cases." which is extremely minimal and vague, providing almost no meaningful information beyond the title. The description fails to follow the required template structure and does not include essential sections such as a detailed description of the issue and solution, test coverage information, or the PR checklist items. While the raw summary indicates the change involves adding a specific test case to waives.txt, the provided description lacks sufficient detail to meet repository standards. The description should be expanded to follow the template structure provided in the repository. Please add a detailed explanation of why this test case is being waived (reference the nvbug or related issue), include information about test coverage, and complete the PR checklist items that are applicable. At minimum, provide context about the specific failed test case and the reason for adding it to the waives list.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[TRTLLM-8638][fix] Add failed cases into waives.txt" follows the specified template format with a valid JIRA ticket identifier, type indicator, and clear summary. The title directly reflects the main change documented in the raw summary, which adds a failed test case to the waives.txt skip list. The title is concise, specific, and clearly communicates the primary purpose of the changeset to reviewers scanning the history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50d4e5b and 3219143.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

390-390: Good — entry follows the established waive list format and pattern.

The new test waive entry for Phi-3.5-MoE-instruct variant with bug reference 5465143 is consistent with related entries at lines 266–269 (which waive other parameter variations of the same test function). The format aligns with the rest of the file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22109 [ run ] triggered by Bot. Commit: 3219143

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251022_LLM_FUNCTION_TEST_1535 branch from 3219143 to 5420980 Compare October 22, 2025 02:08
@xinhe-nv xinhe-nv enabled auto-merge (squash) October 22, 2025 02:08
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22109 [ run ] completed with state SUCCESS. Commit: 3219143
/LLM/main/L0_MergeRequest_PR pipeline #16671 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251022_LLM_FUNCTION_TEST_1535 branch from 5420980 to c2751db Compare October 22, 2025 04:53
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@xinhe-nv xinhe-nv requested a review from jieli-matrix October 22, 2025 04:53
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22123 [ reuse-pipeline ] triggered by Bot. Commit: c2751db

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22123 [ reuse-pipeline ] completed with state SUCCESS. Commit: c2751db
Reusing PR_Github #22109 (Partly Tested) for commit c2751db

@xinhe-nv xinhe-nv merged commit 187cf12 into NVIDIA:main Oct 22, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251022_LLM_FUNCTION_TEST_1535 branch October 22, 2025 06:11
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants