Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Oct 27, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Marked certain test cases as skipped pending resolution of known issues.

@xinhe-nv xinhe-nv marked this pull request as ready for review October 27, 2025 02:44
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251027_LLM_FUNCTION_TEST_1568 branch from 2216b16 to 213a7b4 Compare October 27, 2025 02:44
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Oct 27, 2025
@xinhe-nv xinhe-nv requested a review from jieli-matrix October 27, 2025 02:45
@xinhe-nv xinhe-nv enabled auto-merge (squash) October 27, 2025 02:45
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 27, 2025

📝 Walkthrough

Walkthrough

This PR adds three SKIP entries to the test waives list, addressing known issues in Phi LoRA and Gemma 3.1B disaggregated serving test cases mapped to respective bug IDs.

Changes

Cohort / File(s) Change Summary
Test waives list
tests/integration/test_lists/waives.txt
Added three SKIP entries: one for Phi-3-mini LoRA test (nvbugs/5612313) and two for Gemma 3.1B auto dtype tests (nvbugs/5569696)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file modified with straightforward additions to a waives list
  • No logic changes or complex patterns to evaluate

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • jieli-matrix

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is largely incomplete and does not adequately follow the repository's template. The provided description "waive failed cases." is only a single phrase and fails to explain the issue that prompted these waives or reference the bug numbers (nvbugs/5612313, nvbugs/5569696) associated with the failing test cases. The description is missing the required "Test Coverage" section that should list relevant tests, and the "PR Checklist" section is entirely absent. While the description is not off-topic, it is too minimal and vague to meet the template requirements. The description should be expanded to include a more thorough explanation in the Description section that clarifies why these specific test cases are being waived and references the associated bug numbers. The Test Coverage section should explain which tests are being skipped and why. Additionally, the PR Checklist should be reviewed and the appropriate checkbox should be marked to confirm that the PR follows the project guidelines and doesn't require test cases (since this is a waives file update rather than new feature code).
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][chore] Add failed cases into waives.txt" is directly related to the changeset, which adds three SKIP entries for failed test cases to the waives.txt file. The title accurately captures the main action (adding failed cases) and the target file (waives.txt) in a clear and concise manner. The title is specific enough that a teammate reviewing the git history would immediately understand the purpose of this change without ambiguity.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22563 [ run ] triggered by Bot. Commit: 213a7b4

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251027_LLM_FUNCTION_TEST_1568 branch from 213a7b4 to 2bef92d Compare October 27, 2025 03:16
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22563 [ run ] completed with state SUCCESS. Commit: 213a7b4
/LLM/main/L0_MergeRequest_PR pipeline #17008 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22586 [ reuse-pipeline ] triggered by Bot. Commit: 2bef92d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22586 [ reuse-pipeline ] completed with state SUCCESS. Commit: 2bef92d
Reusing PR_Github #22563 (Partly Tested) for commit 2bef92d

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251027_LLM_FUNCTION_TEST_1568 branch from 2bef92d to 54eacc0 Compare October 27, 2025 06:49
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22596 [ reuse-pipeline ] triggered by Bot. Commit: 54eacc0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22596 [ reuse-pipeline ] completed with state SUCCESS. Commit: 54eacc0
Reusing PR_Github #22563 (Partly Tested) for commit 54eacc0

@xinhe-nv xinhe-nv merged commit 8090c96 into NVIDIA:main Oct 27, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251027_LLM_FUNCTION_TEST_1568 branch October 27, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants