Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Oct 20, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip configuration to exclude seven additional integration and accuracy tests from CI runs.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251020_LLM_FUNCTION_TEST_1542 branch from 4d96f32 to db47869 Compare October 21, 2025 01:07
@xinhe-nv xinhe-nv marked this pull request as ready for review October 21, 2025 01:09
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@xinhe-nv xinhe-nv enabled auto-merge (squash) October 21, 2025 01:10
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Oct 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025

📝 Walkthrough

Walkthrough

The PR adds seven new test entries to the waive-list at tests/integration/test_lists/waives.txt, marking additional tests to be skipped in CI pipelines. No logic, data model, or public API changes are introduced.

Changes

Cohort / File(s) Summary
Waive-list updates
tests/integration/test_lists/waives.txt
Added seven test entries to skip list: three GPU/KV cache-related tests, two distributed serving accuracy tests, and two multimodal inference tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • StanleySun639

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description provided is minimal—just "waive failed cases."—and lacks the required sections specified in the template. The description fails to include a meaningful explanation of the issue or solution, lacks any test coverage information, and does not address the PR checklist items. While the description is on-topic and relates to the changeset, it is substantially incomplete compared to the template requirements and does not provide adequate context for reviewers to understand the motivation or impact of the changes. Expand the PR description to include: (1) a brief explanation of why these specific test cases are being waived and what failures triggered the need; (2) a description of the expected impact on CI; and (3) verification of the PR checklist items, particularly confirming that appropriate reviewers are assigned and that any coding guidelines are followed. This information will help reviewers understand the context and rationale for adding these cases to the waive list.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The pull request title "[TRTLLM-8638][fix] Add failed cases into waives.txt" accurately reflects the main change in the changeset, which adds seven new test cases to the waive-list (tests to be skipped). The title is concise, specific, and clearly describes what the PR does without vague terminology. A teammate scanning the git history would immediately understand that this PR is about updating the test waive list with additional failed test cases.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv xinhe-nv changed the title [TRTLLM-8638][fix] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Oct 21, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21965 [ run ] triggered by Bot. Commit: db47869

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251020_LLM_FUNCTION_TEST_1542 branch from db47869 to 8d7181b Compare October 21, 2025 03:25
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21965 [ run ] completed with state SUCCESS. Commit: db47869
/LLM/main/L0_MergeRequest_PR pipeline #16561 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

Signed-off-by: Xin He (SW-GPU) <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251020_LLM_FUNCTION_TEST_1542 branch from 474dd62 to fcb0eb1 Compare October 21, 2025 04:43
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21999 [ reuse-pipeline ] triggered by Bot. Commit: fcb0eb1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21999 [ reuse-pipeline ] completed with state SUCCESS. Commit: fcb0eb1
Reusing PR_Github #21965 (Partly Tested) for commit fcb0eb1

@xinhe-nv xinhe-nv merged commit 3264d60 into NVIDIA:main Oct 21, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251020_LLM_FUNCTION_TEST_1542 branch October 21, 2025 05:42
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants