Use composer PHP script for PHP_CS setup

[justinbeaty]

Description (*)

There were a few issues with the merge of #2400

1. Hardcoded vendor dir (minor issue, ref)
2. Bash syntax caused an error on Windows (ref)
3. Global PHP version is called even if you do something like /usr/local/opt/[email protected]/bin/php composer install (ref)

I fixed this by making a PHP script that should be platform independent and fix all three issues.

Related Pull Requests

#2400

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Make sure it installs correctly on Linux as it did before -- @sreichel please check this, I don't know how to verify
2. Make sure composer install doesn't throw an error on Windows -- @addison74 please check this
3. Make sure composer install works correctly when calling with a non-system php install -- @fballiano please check this

Questions or comments

I added the dev/scripts directory and an autoload entry in composer.json. The new directory could be used for other composer scripts.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[sreichel]

Nice! For me it works.

Only downside is that exec() is possibly disabled on shared hosts.

[justinbeaty]

Nice! For me it works.

Only downside is that exec() is possibly disabled on shared hosts.

I put a check for exec so we don't terminate the script if it's not available (for example if we did other stuff in that PHP file).

The only thing we could do to get around exec being disabled is if PHP_CS has a PHP API we could call. Not sure it's needed unless people will be running dev tools on shared hosting, though.

[sreichel]

Just an idea ...

• rename class Devel to SetupPhpCs
• change method name to run(Event $event) and maybe add an interface

interface ScriptInterface
{
    public static function run(Event $event);
}

[justinbeaty]

@sreichel The interface is a good idea. I had named it Devel in case we wanted to do other things there without making tons of PHP files, but I'm okay with either way. You'll probably know more about what sort of tools might need to be initialized in the future.

It's getting late here so I'll make the changes tomorrow (or a maintainer is free to push).

[sreichel]

in case we wanted to do other things there without making tons of PHP files, but I'm okay with either way.

This is what i really like from M2 ... Single Responsibility for each class.

[justinbeaty]

👍 on all the changes!

Better use composer plugin?

[fballiano]

This scripts will for sure be used for some other tasks but I think now we should go with #2470 :-)

[sreichel]

This scripts will for sure be used for some other tasks

Definitly! 👍

[addison74]

@justinbeaty's work must be appreciated. Since my finding yesterday and until today there have been constructive discussions. The approach in this PR is interesting and shows that the use of Composer is extremely powerful for this project.

[justinbeaty]

#2470 is better :)

At least we have a framework set up in the case we need custom composer scripts that aren't handled by a plugin.