Skip to content

Use composer-plugin to install phpcs sniffs #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Fixed "if newsletter module disabled, customer backend would blank without notice"
merged 1 commit into from
Aug 22, 2022
Merged

Use composer-plugin to install phpcs sniffs #2470

merged 1 commit into from
Aug 22, 2022

Conversation

@sreichel
Copy link
Contributor

Description (*)

Install phpcs sniffs without own script.

SORRY @justinbeaty for not finding this earlier ... 😢

Related Pull Requests

  1. See Use composer PHP script for PHP_CS setup #2467
  2. See Added some dev tools & code sniffers #2400

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the composer Relates to composer.json label Aug 22, 2022
@github-actions

This comment has been minimized.

Sign in to view
@fballiano fballiano mentioned this pull request Aug 22, 2022
Closed
4 tasks
@fballiano fballiano merged commit d8c52ea into 1.9.4.x Aug 22, 2022
@fballiano fballiano deleted the phpcs-installer branch August 22, 2022 09:06
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit d8c52ea. ± Comparison against base commit ea39086.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addison74 addison74 addison74 approved these changes

+1 more reviewer

@fballiano fballiano fballiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

composer Relates to composer.json

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sreichel @fballiano @addison74