PHP 8.0 | Tests: set up to work with PHP 8.0 identifier name tokens #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() method This adjusts the tests for various utilities to take the different token positions, when PHP 8.0 identifier names are used, into account.
…is used When the PHP 8 identifier name tokenization is used, the `T_NAMESPACE` token for the `namespace` keyword when used as an operator will no longer exist. Similarly, the `T_STRING` for `name` in a `namespace\name` snippet will no longer exist. For certain test cases were setup specifically to prevent false positives/negatives for that type of code. As the "target" token which would be passed to the functions which could have these false positives/negatives, won't exist when the PHP 8 identifier name tokenization is used, these false positives/negatives won't occur and the test becomes redundant. This commit adds selective test skipping for a limited number of test cases where this applies.
…tokenization Add a toggle to retrieve the right token based on the expected tokenization for a test.
…zation Add a toggle to retrieve the right token based on the expected tokenization for a test.
jrfnl
deleted the
php-8.0/tests-set-up-to-work-with-identifier-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per PR #200;
This PR adjusts the existing unit tests for PHPCSUtils to allow for the PHP 8.0 identifier name tokenization, using the new
UtilityMethodTestCase::usesPhp8NameTokensto determine when to set which expectations.