BCFile/GetTokensAsString/GetTokensAsStringTest: make tests independent of PHP 8 identifier names #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of PHP 8 identifier names Related to 201 As the token counts for identifier names are different between PHP < 8 and PHP 8 and depending on which PHPCS version will be used, the test for the `BCFile::getTokensAsString()` method is now unstable. This commit adds a new test case (calculation) which doesn't suffer from that problem to allow for testing with exact token lengths, the same as was previously done with the namespace declaration test. Includes: * In `BCFile/GetTokensAsStringTest`: add an additional test to still cover the namespace declaration test case. * In `GetTokensAsString/GetTokensAsStringTest`: add a test for the new calculation test case.
jrfnl
deleted the
feature/gettokensasstring-change-code-samples-used-in-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #201
As the token counts for identifier names are different between PHP < 8 and PHP 8 and depending on which PHPCS version will be used, the test for the
BCFile::getTokensAsString()method is now unstable.This commit adds a new test case (calculation) which doesn't suffer from that problem to allow for testing with exact token lengths, the same as was previously done with the namespace declaration test.
Includes:
BCFile/GetTokensAsStringTest: add an additional test to still cover the namespace declaration test case.GetTokensAsString/GetTokensAsStringTest: add a test for the new calculation test case.