Skip to content

Conversation

@maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Oct 11, 2018

Renamed VolumeRestrictionTransferManager to LockupVolumeRestrictionTransferManager.

Note
Name in factory has not been changed as LockupVolumeRestrictionTransferManager does not fit in bytes32

@satyamakgec
Copy link
Contributor

Couldn't we use the TM as the suffix for TransferManager that will reduce the contract name and also open the space for writing the clear name for the TM?
so it will be like LockupVolumeRestrictionTM, PercentageTM, ManualApprovalTM, SingleTradeVolumeRestricitonTM etc.
using this we can easily return the name as a bytes32 datatype.
@pabloruiz55 WDYT?

@pabloruiz55
Copy link
Contributor

@satyamakgec My concern is that introduces some discrepancies with older versions.
Let's start by doing that with newer TM modules only for now. So, @maxsam4 for this one and single trade let's rename them to xxxTM

@satyamakgec satyamakgec merged commit 1dd8191 into development-1.5.0 Oct 11, 2018
@maxsam4 maxsam4 deleted the rename-vrtm branch January 11, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants