Skip to content

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Jul 15, 2021

What does this changes

Add more spelling engine

  • Add symspellpy with unigram & bigram from TNC - symspellpy is a Python port of SymSpell v6.5.
  • Add Phunspell - A pure Python spell checker utilizing spylls a port of Hunspell.
  • Add spell_sent & correct_sent function

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Jul 15, 2021

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 18:1: E402 module level import not at top of file

Comment last updated at 2021-07-21 18:01:48 UTC

@wannaphong wannaphong requested a review from bact July 15, 2021 17:03
@wannaphong
Copy link
Member Author

phunspell is not working with python 3.6.

@wannaphong wannaphong changed the title Add correct engine [WIP] Add correct engine Jul 15, 2021
@coveralls
Copy link

coveralls commented Jul 15, 2021

Coverage Status

Coverage decreased (-0.2%) to 95.837% when pulling 1d55553 on add-correct-engine into ad20a1e on dev.

@wannaphong wannaphong changed the title [WIP] Add correct engine Add correct engine Jul 15, 2021
@wannaphong
Copy link
Member Author

@bact
Copy link
Member

bact commented Jul 16, 2021

python 3.6.

Python 3.6 EOL is 2021-12-23, only months away from now.
Maybe have to consider if the next version of PyThaiNLP will going to support 3.6 after its EOL or not.

@wannaphong
Copy link
Member Author

python 3.6.

Python 3.6 EOL is 2021-12-23, only months away from now.
Maybe have to consider if the next version of PyThaiNLP will going to support 3.6 after its EOL or not.

End of support for Python 3.6 in the next version of PyThaiNLP #592

@wannaphong wannaphong merged commit 58615bc into dev Jul 22, 2021
@wannaphong wannaphong deleted the add-correct-engine branch July 29, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants