Skip to content

Conversation

wannaphong
Copy link
Member

What does this changes

Retrained sentenceseg_crfcut.model for PyThaiNLP 2.4

What was wrong

After #557 & #562, We needs to retrained all model in PyThaiNLP before we release PyThaiNLP 2.4 because dict & newmm has update.

How this fixes it

Description of how the changes fix the issue.

Fixes #581

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@wannaphong
Copy link
Member Author

@wannaphong
Copy link
Member Author

It is same f1-score.

@wannaphong wannaphong added this to the 2.4 milestone Jul 21, 2021
@wannaphong
Copy link
Member Author

wannaphong commented Jul 21, 2021

before 4.32 MB after 3.9 MB ...

@cstorm125 @bact What are you think about it?

@coveralls
Copy link

coveralls commented Jul 21, 2021

Coverage Status

Coverage decreased (-0.05%) to 95.778% when pulling 94d24b3 on add-retrained-crfcut-model into 259daf1 on dev.

@bact
Copy link
Member

bact commented Jul 21, 2021

before 4.32 MB after 3.9 MB ...

@cstorm125 @bact What are you think about it?

Maybe related to the smaller vocab size?
words_th.txt is smaller in new version of PyThaiNLP after removing misspelled words.

Guessing.

@wannaphong
Copy link
Member Author

before 4.32 MB after 3.9 MB ...
@cstorm125 @bact What are you think about it?

Maybe related to the smaller vocab size?
words_th.txt is smaller in new version of PyThaiNLP after removing misspelled words.

Guessing.

Same.

@wannaphong wannaphong merged commit 271908e into dev Jul 22, 2021
@wannaphong wannaphong deleted the add-retrained-crfcut-model branch July 29, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retrained Model for PyThaiNLP 2.4

3 participants