[🐞] custom service worker is not registered in 1.16.0

[makinghappen]

Which component is affected?

Qwik Runtime

Describe the bug

navigator.serviceWorker.register("/service-worker.js")is not being generated in qwik 1.16.0

qwik 1.15.0

        <script type="module" q:key="7s_7" q:head>
            "serviceWorker"in navigator ? navigator.serviceWorker.register("/service-worker.js").catch(r => console.error(r)) : console.log("Service worker not supported in this browser.")
        </script>

qwik 1.16.0

        <script type="module" q:key="5B_7" q:head>
            "serviceWorker"in navigator && navigator.serviceWorker.getRegistrations().then(r => {
                for (const e of r) {
                    const c = "/service-worker.js".split("/").pop();
                    e.active?.scriptURL.endsWith(c || "service-worker.js") && e.unregister().catch(console.error)
                }
            }
            ),
            "caches"in window && caches.keys().then(r => {
                const e = r.find(c => c.startsWith("QwikBuild"));
                e && caches.delete(e).catch(console.error)
            }
            ).catch(console.error)
        </script>

Reproduction

n/a

Steps to reproduce

build with service worker and 1.16.0

System Info

qwik 1.16.0

Additional Information

No response

[gioboa]

Hi @makinghappen we are moving away from the service worker approach
You can see in the release note few details and in the blog post you can read more about that.

[makinghappen]

@gioboa that's great for qwik performance, are there recommendations how should now custom service workers be integrated?

[gioboa]

yep, you can find the answer to our Discord server. There is a nice discussion about this topic.
So I'm closing this issue for now, feel free to re-open it if it's still an issue for you. Thanks.

[makinghappen]

@gioboa had a chat on discord, they say that custom service worker should not be unregistered, so it is indeed a bug

[gioboa]

Oh I see, it's a custom service worker, not the Qwik worker. I'll change the title.

[gioboa]

@makinghappen you can try this pre-release btw
#7872 (comment)

[makinghappen]

@gioboa just tried 1.16.1, and found that service-worker is not built at all from my custom src/routes/service-worker.ts