fix(qwik-city): custom service-worker.ts code is also being unregistered #7872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce1f74e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
maiieul
changed the title
gioboa
reviewed
Aug 27, 2025
packages/qwik-city/src/buildtime/runtime-generation/generate-service-worker.ts
Outdated
Show resolved
Hide resolved
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
gioboa
previously approved these changes
Aug 27, 2025
gioboa
reviewed
Aug 27, 2025
wmertens
reviewed
Aug 27, 2025
wmertens
reviewed
Aug 27, 2025
Co-authored-by: Giorgio Boa <[email protected]>
maiieul
force-pushed
the
fix-service-worker-unregistration-only-for-non-custom-uses
branch
from
6b0b783 to
f507f60
Compare
wmertens
reviewed
Aug 27, 2025
maiieul
force-pushed
the
fix-service-worker-unregistration-only-for-non-custom-uses
branch
2 times, most recently
from
4e05371 to
545b5bf
Compare
maiieul
force-pushed
the
fix-service-worker-unregistration-only-for-non-custom-uses
branch
from
545b5bf to
ce1f74e
Compare
gioboa
approved these changes
Aug 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7856
What is it?
Description
Now custom service-worker implementation will keep working, while projects that removed their service-worker.ts files will unregister their service-worker.js and related cache.
Checklist
pnpm change