refactor(symbol): replace symbol polyfill to separate package

[kwonoj]

Description:

This PR replaces existing symbol declaration into symbol-observable package.

Related issue (if exists):

closes #1636

Notes
Blocked by benlesh/symbol-observable#4 .

[benlesh]

@kwonoj FYI: the issue is resolved and a new version of symbol-observable has been published.

[benlesh]

Nitpick: I prefer $$name for symbols. Can we use $$observable? It's consistent with the rest of the library.

[kwonoj]

Absolutely, updated per suggestion.

[benlesh]

So just one nitpick, other than that, it LGTM.

[kwonoj]

I'll wait travis to be happy before check this in.

[benlesh]

Well, right now it looks like CJS will compile, but ES6 will not, for whatever reason. When compiling the ES6 it can't find the module.

[benlesh]

Specifically: npm run build_cjs works, but npm run build_es6 does not

[kwonoj]

Yes, noticed that, thanks for pointing out. Looking into it now..

[kwonoj]

Just fyi, moduleResolution solves es15 build but not systemjs-builder complains about external dependencies. :/ looking into it also..

[kwonoj]

I've changed this to dependencies instead of devDependencies since it's required dependency not only dev perspective.

[kwonoj]

@Blesh - I've updated 2 parts more,

• symbol-observable is now dependency instead of devDependency
• systemjs bundler will mark symbol-observable externally resolved, let each consumer to provide it

and I believe both need to be approved. Will leave this to get suggestions & corrections if there's wrong I did.

[robwormald]

the use case for the system bundles is to provide tool-free usage, so it seems to be it would be simpler just to include it, as its unlikely to be provided elsewhere, no?

[kwonoj]

so it seems to be it would be simpler just to include it, as its unlikely to be provided elsewhere, no?

: Yes, I wasn't sure if current change's legit so would like to ask to confirm it. I'll try to include it as well, my initial attempt wasn't successful while resolving external modules.

[kwonoj]

Updated PR as suggested.

[kwonoj]

Merged with b626d97 .

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.