Skip to content

Fix evals #7547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2025
Merged

Fix evals #7547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/evals/Dockerfile.runner
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ RUN mkdir -p \
packages/ipc \
packages/telemetry \
packages/types \
packages/cloud \
Copy link
Contributor

@roomote roomote bot Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition here. The cloud package is properly included with the trailing backslash, maintaining consistency with the rest of the mkdir command.

src \
webview-ui

Expand All @@ -104,6 +105,7 @@ COPY ./packages/evals/package.json ./packages/evals/
COPY ./packages/ipc/package.json ./packages/ipc/
COPY ./packages/telemetry/package.json ./packages/telemetry/
COPY ./packages/types/package.json ./packages/types/
COPY ./packages/cloud/package.json ./packages/cloud/
COPY ./src/package.json ./src/
COPY ./webview-ui/package.json ./webview-ui/

Expand Down
4 changes: 3 additions & 1 deletion packages/evals/Dockerfile.web
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ RUN mkdir -p \
packages/config-typescript \
packages/evals \
packages/ipc \
packages/types
packages/types \
packages/cloud
Copy link
Contributor

@roomote roomote bot Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? The line is missing a trailing backslash for consistency with the other lines in this mkdir command. Consider:

Suggested change
packages/cloud
packages/cloud \n```
This would maintain consistency with the formatting pattern used for other directories.


COPY ./package.json ./
COPY ./pnpm-lock.yaml ./
Expand All @@ -43,6 +44,7 @@ COPY ./packages/config-typescript/package.json ./packages/config-typescript/
COPY ./packages/evals/package.json ./packages/evals/
COPY ./packages/ipc/package.json ./packages/ipc/
COPY ./packages/types/package.json ./packages/types/
COPY ./packages/cloud/package.json ./packages/cloud/

RUN pnpm install

Expand Down
Loading